Feat: add comparison_to_empty #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xLucqs
suggested changes
Oct 1, 2024
Comment on lines
40
to
42
| fn create_diagnostic(message: &str, stable_ptr: SyntaxStablePtrId, severity: Severity) -> PluginDiagnostic { | ||
| PluginDiagnostic { stable_ptr, message: message.to_string(), severity } | ||
| } |
There was a problem hiding this comment.
don't need this function, directly create the diagnostic
| @@ -11,3 +11,4 @@ pub mod loops; | |||
| pub mod manual; | |||
| pub mod panic; | |||
| pub mod single_match; | |||
| // pub mod comparison_to_empty; | |||
|
Alright @0xLucqs |
…iagnostic where it's needed
|
@0xLucqs i have made the requested changes |
|
fix clippy and don't forget to format |
ok |
|
you need to add the tests to the test file similarly to how it's done with others |
|
@0xLucqs |
|
fix the tests, remove the useless added file and restore the cargo.lock plz |
|
and resolve conflicts |
alright |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #74
@0xLucqs
This is a draft PR
Implementation
Checks for comparing to an empty slice such as [], and suggests using .is_empty() where applicable.