Feat: Add manual assert #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xLucqs
suggested changes
Sep 23, 2024
crates/cairo-lint-core/src/fix.rs
Outdated
| if let Expr::InlineMacro(inline_macro) = &statement_expr.expr(db) { | ||
| let panic_message = inline_macro.arguments(db).as_syntax_node().get_text_without_trivia(db); | ||
| let condition_text = condition.as_syntax_node().get_text_without_trivia(db); | ||
| let assert_condition = condition_text.trim_start_matches('!'); |
There was a problem hiding this comment.
don't do that, take the if condition from the Expr::If
0xLucqs
suggested changes
Sep 25, 2024
crates/cairo-lint-core/src/fix.rs
Outdated
Comment on lines
523
to
524
| panic_message.trim_matches(&['(', ')'][..]).replace("\"", "").trim(), | ||
| condition_text.split('.').next().unwrap_or(&condition_text), |
| @@ -0,0 +1,79 @@ | |||
| //! > check-if-then | |||
There was a problem hiding this comment.
add more tests for example one with if else don't only check the happy path you need to think of edge cases
|
Hey i'll close this, as there's still plenty of work to do and we won't have time to do it by the end of the week. I'll still pay you though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manual_assert#62