Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ok_expect lint #115

Open
BrunoAmbricca opened this issue Sep 24, 2024 · 0 comments
Open

Add ok_expect lint #115

BrunoAmbricca opened this issue Sep 24, 2024 · 0 comments

Comments

@BrunoAmbricca
Copy link
Contributor

What it does
Checks for usage of ok().expect(..).

Why is this bad?
Because you usually call expect() on the Result directly to get a better error message.

Known problems
The error type needs to implement Debug

Example
x.ok().expect("why did I do this again?");

Use instead:
x.expect("why did I do this again?");

@mkaput mkaput added this to cairo-lint Dec 9, 2024
@github-project-automation github-project-automation bot moved this to Triage in cairo-lint Dec 9, 2024
@mkaput mkaput moved this from Triage to Backlog in cairo-lint Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant