Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Topology] Apply new factory registration mechanism #5012

Merged
merged 7 commits into from
Oct 4, 2024

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Sep 23, 2024

See

[ci-depends-on https://github.com/SofaDefrost/ModelOrderReduction/pull/143]
[ci-depends-on https://github.com/sofa-framework/SofaPython3/pull/458]
[ci-depends-on https://github.com/SofaDefrost/SoftRobots/pull/305]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: status wip Development in the pull-request is still in progress pr: new feature Implement a new feature pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress pr: status to review To notify reviewers to review this pull-request labels Sep 23, 2024
@fredroy fredroy added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Sep 24, 2024
@fredroy
Copy link
Contributor Author

fredroy commented Sep 24, 2024

[ci-build][with-all-tests][force-full-build]

@sofa-framework sofa-framework deleted a comment from sofabot Sep 24, 2024
@sofabot
Copy link
Collaborator

sofabot commented Sep 24, 2024

[ci-depends-on] detected during build #6.

To unlock the merge button, you must

@sofa-framework sofa-framework deleted a comment from sofabot Sep 24, 2024
@fredroy
Copy link
Contributor Author

fredroy commented Sep 24, 2024

[ci-build][with-all-tests][force-full-build]

@sofabot
Copy link
Collaborator

sofabot commented Sep 24, 2024

[ci-depends-on] detected during build #7.

To unlock the merge button, you must

@sofa-framework sofa-framework deleted a comment from sofabot Sep 24, 2024
@alxbilger
Copy link
Contributor

What happens if you forget the required plugins in the ci-dependent PRs?

@fredroy
Copy link
Contributor Author

fredroy commented Sep 25, 2024

What happens if you forget the required plugins in the ci-dependent PRs?

An error message and no object instantiated.

@alxbilger
Copy link
Contributor

And why did it work before and not now?

@fredroy
Copy link
Contributor Author

fredroy commented Sep 25, 2024

And why did it work before and not now?

Because with the "binary" dependencies, the registration was made implicitly when the system are loading the dll, unbeknownst to the pluginmanager .
So for example when one is importing explicitly the plugin Sofa.Component.Visual, the OS is also loading the plugin (dyn.library) Sofa.Component.Topology.Container.Grid implicitly, and this triggered the registration of all Grid components because the registration is (was) automatic. But from the PluginManager point of view Sofa.Component.Topology.Container.Grid is/was not loaded.

@sofabot
Copy link
Collaborator

sofabot commented Sep 27, 2024

[ci-depends-on] detected during build #8.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 2, 2024
@sofabot
Copy link
Collaborator

sofabot commented Oct 4, 2024

[ci-depends-on] detected during build #9.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍

@sofabot
Copy link
Collaborator

sofabot commented Oct 4, 2024

[ci-depends-on] detected during build #10.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍

@hugtalbot hugtalbot merged commit 38ecbea into sofa-framework:master Oct 4, 2024
9 of 11 checks passed
@hugtalbot hugtalbot deleted the register_topology branch October 4, 2024 13:54
@hugtalbot hugtalbot modified the milestones: v25.06, v24.12 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new feature Implement a new feature pr: status ready Approved a pull-request, ready to be squashed
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants