Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pop with subscription support? #3

Open
gavin-norman-sociomantic opened this issue Nov 23, 2017 · 0 comments
Open

Add Pop with subscription support? #3

gavin-norman-sociomantic opened this issue Nov 23, 2017 · 0 comments

Comments

@gavin-norman-sociomantic

(Most of the work will be in dmqproto, just adding the issue here as a place-holder, for now.)

In the future, when most consumers have been moved over to using subscriber names, the Pop request (which currently cannot work on a subscribed channel) will become defunct. We do have possible use cases for Pop (e.g. when the user wants to strictly limit the input flow), so it'd be nice to get it working with subscribed channels.

It seems like simply adding an optional subscriber name to the Pop request (the same as Consume) should do the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant