Skip to content
This repository has been archived by the owner on Oct 5, 2023. It is now read-only.

git reviewrequest fails when pull request already exists #37

Open
mandrews opened this issue May 2, 2013 · 1 comment
Open

git reviewrequest fails when pull request already exists #37

mandrews opened this issue May 2, 2013 · 1 comment

Comments

@mandrews
Copy link

mandrews commented May 2, 2013

Sometimes it's nice to use the Markdown preview functionality within the Github pull-request UI. At the moment, git reviewrequest fails when a pull request already exists. IMO it would be nice to automatically generate a stream message from the existing pull-request and notify your review buddy.

Everything up-to-date
Creating pull request for fix-oembed-ogp against master in socialcast/socialcast
Failed to create pull request: Validation Failed
/Users/mandrews/.rvm/gems/ruby-1.9.3-p194-turbo/gems/socialcast-git-extensions-3.1.4/lib/socialcast-git-extensions/github.rb:47:in `throw': uncaught throw 422 Unprocessable Entity: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for socialcast:fix-oembed-ogp."}]} (ArgumentError)
        from /Users/mandrews/.rvm/gems/ruby-1.9.3-p194-turbo/gems/socialcast-git-extensions-3.1.4/lib/socialcast-git-extensions/github.rb:47:in `rescue in create_pull_request'
        from /Users/mandrews/.rvm/gems/ruby-1.9.3-p194-turbo/gems/socialcast-git-extensions-3.1.4/lib/socialcast-git-extensions/github.rb:34:in `create_pull_request'
        from /Users/mandrews/.rvm/gems/ruby-1.9.3-p194-turbo/gems/socialcast-git-extensions-3.1.4/lib/socialcast-git-extensions/cli.rb:42:in `reviewrequest'
        from /Users/mandrews/.rvm/gems/ruby-1.9.3-p194-turbo/gems/thor-0.16.0/lib/thor/task.rb:27:in `run'
        from /Users/mandrews/.rvm/gems/ruby-1.9.3-p194-turbo/gems/thor-0.16.0/lib/thor/invocation.rb:120:in `invoke_task'
        from /Users/mandrews/.rvm/gems/ruby-1.9.3-p194-turbo/gems/thor-0.16.0/lib/thor.rb:275:in `dispatch'
        from /Users/mandrews/.rvm/gems/ruby-1.9.3-p194-turbo/gems/thor-0.16.0/lib/thor/base.rb:425:in `start'
        from /Users/mandrews/.rvm/gems/ruby-1.9.3-p194-turbo/gems/socialcast-git-extensions-3.1.4/bin/git-reviewrequest:4:in `<top (required)>'
        from /Users/mandrews/.rvm/gems/ruby-1.9.3-p194-turbo/bin/git-reviewrequest:19:in `load'
        from /Users/mandrews/.rvm/gems/ruby-1.9.3-p194-turbo/bin/git-reviewrequest:19:in `<main>'
        from /Users/mandrews/.rvm/gems/ruby-1.9.3-p194-turbo/bin/ruby_noexec_wrapper:14:in `eval'
        from /Users/mandrews/.rvm/gems/ruby-1.9.3-p194-turbo/bin/ruby_noexec_wrapper:14:in `<main>'
@f1sherman
Copy link
Contributor

+1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants