[Frontend] The loading state only last for 5 seconds when reporting #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xiawpohr
reviewed
Nov 20, 2024
| {isSuccess && <ReportFormSubmitSuccess onClose={onCloseDialog} />} | ||
| <ReportFormSubmitting | ||
| isOpen={isSubmitting} | ||
| onClose={onCloseDialog} |
There was a problem hiding this comment.
按下右上角的 close button 時，沒有關閉 ReportFormSubmitting 哦
| clearTimeout(timer) | ||
| } | ||
| } | ||
| }, [isPending, onCloseDialog]) |
There was a problem hiding this comment.
如果當前 epoch 已做過 user state transition 時，reportComment 的時間會少於 5 秒，因而導致 5 秒過後不會自動關閉 ReportFormSubmitting。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
修改 report flow 與更新相關組件
Linked Issue
close #554
Details