Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UST-240] [Frontend] Improve the commenting process to make it more convenient and concise #569

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[UST-240] [Frontend] Improve the commenting process to make it more convenient and concise #569

wants to merge 1 commit into from

Conversation

badukwei
Copy link
Collaborator

@badukwei badukwei commented Nov 4, 2024 •
edited
Loading

Summary

用戶點擊主頁中的評論圖示按鈕時，立即轉到貼文頁面並打開評論對話框。

Linked Issue

close #553

Details

利用 route 去判斷要不要打開評論框

@Xiawpohr
Copy link
Collaborator

@badukwei The issue title and description is not matched. Please fix the title and linked issue.

@Xiawpohr
Copy link
Collaborator

建議可以用 searchParams 來實作這個功能，好處是我們可以將不同參數對應到不同的功能上，讓 url 更加語義化。
例如：

  • /posts/{id}/#comments -> 表示使用者會去到貼文頁面，並直接捲動到評論區塊
  • /posts/{id}/?leaveComment=1 -> 表示使用者會去到貼文頁面，並打開評論對話框
  • /posts/{id}/#comments?leaveComment=1 -> 表示使用者會去到貼文頁面，並直接捲動到評論區塊和打開評論對話框

@badukwei badukwei changed the title [Frontend] Display progress bar under Epoch timer when user votes a post [UST-240] [Frontend] Improve the commenting process to make it more convenient and concise Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xiawpohr Xiawpohr Awaiting requested review from Xiawpohr

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UST-240] [Frontend] Improve the commenting process to make it more convenient and concise
2 participants
@badukwei @Xiawpohr