[Frontend] Display progress bar under Epoch timer when user votes a post #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xiawpohr
reviewed
Nov 20, 2024
| @@ -7,6 +8,7 @@ import { immer } from 'zustand/middleware/immer' | |||
| export enum ActionType { | |||
| Post = 'post', | |||
| Comment = 'comment', | |||
| Vote = 'ote', | |||
| epoch: number | null | ||
| identityNonce: number | ||
| } | ||
|
|
There was a problem hiding this comment.
建議可以分成兩種 Action ：UpvoteData 和 DownvoteData，避免 ActionData 裡面有太多層級。這樣在 getActionMessage 和 getActionSubject 這兩個 function 就不用多一個參數與 Action 不相關的參數。把 vote 的邏輯留在 useVotes 就好。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
使用者投票時新增進度條
Linked Issue
close #550
Details
更新 action store 新增 voting 相關的動作，並且更新顯示文字以及 ui