Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for duplicate data to switch-configuration data files #739

Open
kylerisse opened this issue Mar 16, 2024 · 1 comment
Open

Add checks for duplicate data to switch-configuration data files #739

kylerisse opened this issue Mar 16, 2024 · 1 comment

Comments

@kylerisse
Copy link
Member

Description

Had concerns that the current pytest based data validation only addressed individual fields and didn't have any insight into duplicate data throughout an entire file. This was addressed in this PR. This PR only addressed the files in /facts but not yet for switch-configuration/config. That needs to be added.

Acceptance Criteria

  • duplication checks for columns that should be unique added to CI
@owendelong
Copy link
Collaborator

There are a lot of places where data appears to be duplicate in that area but actually needs to be duplicate.

For example, the VLAN list on many trunks will be identical.

There are others. Let's discuss this in more detail before too much implementation gets out of hand. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants