Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not build with ocamlc >= 4.06 #29

Open
sampollard opened this issue Mar 31, 2021 · 1 comment
Open

Does not build with ocamlc >= 4.06 #29

sampollard opened this issue Mar 31, 2021 · 1 comment

Comments

@sampollard
Copy link

If you compile with e.g. ocamlc 4.06 you get a bunch of warnings like this:

If you need to stay compatible with OCaml < 4.07, you can use the 
stdlib-shims library: https://github.com/ocaml/stdlib-shims

Then an error:

ocamlc -c -I b_and_b -I INTERVAL more_num.mli
File "more_num.mli", line 13, characters 16-23:
13 | val numerator : Num.num -> Big_int.big_int
                     ^^^^^^^
Error: Unbound module Num
make: *** [Makefile:183: more_num.cmi] Error 2

I got around this by doing ocaml switch create 4.05.0, which then built successfully. You may want to update the README.md. This was on Ubuntu 20.04.

@monadius
Copy link
Member

monadius commented Apr 1, 2021

Another way to solve your compilation issue is to install the legacy Num library for OCaml 4.06: opam install num. I will update the Readme file with this info.

I don't get any warnings about Stdlib on macOS with OCaml 4.06.1 and OCaml 4.07.1. I am going to test FPTaylor on Ubuntu and decide the best course of action: require stdlib-shims for OCaml < 4.07 or update the minimal required OCaml version to 4.07.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants