Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

release-notes-preview gets broken by the <scope> portion of a commit header #31

Open
bradennapier opened this issue Aug 2, 2020 · 1 comment
Open

release-notes-preview gets broken by the <scope> portion of a commit header #31

bradennapier opened this issue Aug 2, 2020 · 1 comment
Assignees
@Shesekino
Labels
bug Something isn't working enhancement New feature or request

Comments

@bradennapier
Copy link

bradennapier commented Aug 2, 2020 •
edited
Loading

Tried 1.6.2 and it didn't seem to work I had a line (feat(play): test) which should have generated notes for that and it didnt post anything to the PR.

processing line: ea19f82 feat(play): test
adding "test (ea19f82)" to others

The actual beta release notes were created, however:

image
@Shesekino Shesekino changed the title Still didn't work release-notes-preview gets broken by the <scope> portion of a commit header Aug 3, 2020
@Shesekino Shesekino self-assigned this Aug 3, 2020
@Shesekino Shesekino added bug Something isn't working enhancement New feature or request labels Aug 3, 2020
@Shesekino
Copy link
Contributor

Shesekino commented Aug 3, 2020 •
edited
Loading

Thanks for the details :)
When I wrote the code here, I completely neglected the part of the commit header that deals with the "scope":
<type>(<scope>): <subject>
Because I never used it.
Now I realise it's used and should be supported.

@dezren39 dezren39 mentioned this issue Sep 19, 2020
Open
@ghost ghost mentioned this issue May 18, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Shesekino Shesekino

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support scoped commits
2 participants
@Shesekino @bradennapier