Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promises API rejects even when operation successfully completes. #19

Open
repalash opened this issue Feb 3, 2024 · 0 comments
Open

Comments

@repalash
Copy link

repalash commented Feb 3, 2024

The code checks for stderr.length to identify if the process existed successfully, but incase when logging is enable with -v or --log-level, it's written to stderr, which makes the promise API reject.

Here is a sample code that doesn't work:

await rclone.promises('command', {
    'progress': true, 'log-level': process.env.DEBUG ? 'DEBUG' : 'INFO'
  },
);

One that works:

const childProcess = rclone('command', {
    'progress': true, 'log-level': process.env.DEBUG ? 'DEBUG' : 'INFO',
    stdio: 'inherit',
  },
);
await new Promise((resolve, reject) => {
  childProcess.on('exit', (code) => {
    if (code === 0) {
      resolve();
    } else {
      reject(new Error(`Failed with code ${code}`));
    }
  });
});
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant