Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a custom path in CollectorParams #118

Open
emiliauskas-fuzzy opened this issue Dec 22, 2018 · 2 comments
Open

Add support for a custom path in CollectorParams #118

emiliauskas-fuzzy opened this issue Dec 22, 2018 · 2 comments

Comments

@emiliauskas-fuzzy
Copy link

Library version:
0.6.0
Expected behavior:
able to set custom path for target collector
Actual behavior:
right now its not possible because of port append (443 or 80 or custom) which messes up actual path
Steps to reproduce:

just try to set
AsyncEmitter.createAndStart("collector.host.com/somepath", port = None, https = true)
and tracker will transform it to https://collector.host.com/somepath:443 instead of https://collector.host.com:443/somepath

I think easiest would be to update CollectorParams with extra field path: Option[String] which would be append to the uri.

@BenFradet
Copy link

Good idea 👍

@BenFradet BenFradet changed the title add custom path support in CollectorParams Add support for a custom path in CollectorParams Dec 24, 2018
@emiliauskas-fuzzy
Copy link
Author

@BenFradet thanks, I think it can be easily added together with this URI PR done by @chuwy just by allowing path set here: 283ca5d#diff-07448d20291b73583919ed006d083f3bR156

@chuwy chuwy added this to the 0.7.0 milestone Dec 27, 2018
@paulboocock paulboocock removed this from the 0.7.0 milestone Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants