Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placeholder for pre-R73 enriched event support #5

Open
alexanderdean opened this issue Mar 21, 2016 · 10 comments
Open

Placeholder for pre-R73 enriched event support #5

alexanderdean opened this issue Mar 21, 2016 · 10 comments
Assignees
@ihortom

Comments

@alexanderdean
Copy link
Member

alexanderdean commented Mar 21, 2016 •
edited
Loading

We would use the count of fields to determine which version of the enriched event we are working with. See also: #2, #4.

Release Column count Additions Removals
R73 131 xxx xxx
@alexanderdean alexanderdean self-assigned this Mar 21, 2016
@alexanderdean alexanderdean changed the title Placeholder for pre-R75 support Placeholder for pre-R75 enriched event support Mar 21, 2016
@alexanderdean alexanderdean changed the title Placeholder for pre-R75 enriched event support Placeholder for pre-R73 enriched event support Jul 12, 2016
@alexanderdean alexanderdean mentioned this issue Sep 8, 2016
Open
@alexanderdean
Copy link
Member Author

Assigning to @ihortom to populate the release table...

@ihortom
Copy link

ihortom commented Sep 9, 2016 •
edited
Loading

@alexanderdean - here's my view

Release Column count Additions Removals Renamings
>=R73 (v0.8.0) 128 unstruct_event contexts derived_contexts
R71-R72 (v0.7.0) 131 true_tstamp event_vendor event_name event_format event_version event_fingerprint dvce_tstamp renamed to dvce_created_tstamp
R63-R70 (v0.6.0) 125 tr_currency tr_total_base tr_tax_base tr_shipping_base ti_currency ti_price_base base_currency geo_timezone mkt_clickid mkt_network etl_tags dvce_sent_tstamp refr_domain_userid refr_dvce_tstamp derived_contexts domain_sessionid derived_tstamp
<=R62 (v0.5.0) 108

@alexanderdean
Copy link
Member Author

Looks great, though I don't think we ever removed derived_tstamp:

https://github.com/snowplow/snowplow/blob/master/4-storage/redshift-storage/sql/atomic-def.sql#L181

@ihortom
Copy link

ihortom commented Sep 9, 2016

According to release notes we renamed derived_tstamp to dvce_created_tstamp

@alexanderdean
Copy link
Member Author

Have you got a link to that Ihor? I think we renamed dvce_tstamp to dvce_created_tstamp...

@ihortom
Copy link

ihortom commented Sep 9, 2016

You are right, amended the table

@alexanderdean
Copy link
Member Author

Looks great, thanks. Actually fewer iterations that I was remembering...

@bogaert
Copy link

bogaert commented Oct 11, 2016

Is there a reason not to add a renmaings column, in addition to additions and removals? That will make it a little clearer that dvce_tstamp was renamed to, not replaced with, dvce_created_tstamp.

@alexanderdean
Copy link
Member Author

Good idea, let's make that change

@ihortom
Copy link

ihortom commented Oct 11, 2016

Updated the table

@alexanderdean alexanderdean mentioned this issue Mar 8, 2017
Closed
@rolanddb rolanddb mentioned this issue Mar 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ihortom ihortom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexanderdean @bogaert @ihortom