Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor v1 release filters #192

Closed
colmsnowplow opened this issue Aug 8, 2022 · 0 comments
Closed

Refactor v1 release filters #192

colmsnowplow opened this issue Aug 8, 2022 · 0 comments
Milestone

Comments

@colmsnowplow
Copy link
Collaborator

In reviewing the v1 PR, there were some issues with filtering which were difficult to map because of how the code was structured. This issue documents the changes made in order to resolve that issue, and fixup some of the issues in the filtering feature which can be found in this PR.

Commits referenced below will be squashed and rebased - but keeping the references here in order to refer to the specific changes in turn.

  • Code structure factored to be more testable and to separate logic appropriately: 5dcaaa4

This also changes the API for unstruct filters here to make the checks on event name and version explicit on configuration.


Additionaly, the following are things that I think we should improve, but shouldn't block v1 release for. Documenting them here in the name of completeness:

@colmsnowplow colmsnowplow added this to the Release 1.0.0 milestone Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant