-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor v1 release filters #192
Milestone
Comments
colmsnowplow
added a commit
that referenced
this issue
Aug 11, 2022
colmsnowplow
added a commit
that referenced
this issue
Aug 11, 2022
colmsnowplow
added a commit
that referenced
this issue
Aug 11, 2022
colmsnowplow
added a commit
that referenced
this issue
Aug 12, 2022
colmsnowplow
added a commit
that referenced
this issue
Aug 12, 2022
colmsnowplow
added a commit
that referenced
this issue
Aug 12, 2022
colmsnowplow
added a commit
that referenced
this issue
Aug 12, 2022
colmsnowplow
added a commit
that referenced
this issue
Aug 12, 2022
colmsnowplow
added a commit
that referenced
this issue
Aug 12, 2022
colmsnowplow
added a commit
that referenced
this issue
Aug 12, 2022
colmsnowplow
added a commit
that referenced
this issue
Aug 12, 2022
colmsnowplow
added a commit
that referenced
this issue
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In reviewing the v1 PR, there were some issues with filtering which were difficult to map because of how the code was structured. This issue documents the changes made in order to resolve that issue, and fixup some of the issues in the filtering feature which can be found in this PR.
Commits referenced below will be squashed and rebased - but keeping the references here in order to refer to the specific changes in turn.
This also changes the API for unstruct filters here to make the checks on event name and version explicit on configuration.
Factor out compiling regexes so that this happens only once on startup: b2c0d68
When no value is returned, the filter always evaluates to
false
, and when a nil value is returned we don't match against nil, but against the string<nil>
: e643a52Use
Compile()
instead ofMustCompile()
to avoid panics: 61dbba8Issue with the analytics sdk's API (Return
[]interface{}
from GetContextValue snowplow-golang-analytics-sdk#36) leads to error when value doesn't exist, rather than simply matching nil. db5841eIncorrect tests: 5dcaaa4 and b77d244
Additionaly, the following are things that I think we should improve, but shouldn't block v1 release for. Documenting them here in the name of completeness:
The text was updated successfully, but these errors were encountered: