Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for GCP auth via env vars #181

Closed
colmsnowplow opened this issue Aug 1, 2022 · 0 comments
Closed

Remove support for GCP auth via env vars #181

colmsnowplow opened this issue Aug 1, 2022 · 0 comments
Milestone

Comments

@colmsnowplow
Copy link
Collaborator

Originally, we allowed the user to provide a b64 encoded representation of GCP service account credentials, we stored that in a file and set the GOOGLE_APPLICATION_CREDENTIALS env var to the path of that file. The reason for this was to support AWS Lambda and GCP cloudfunction deployments.

In release/1.0.0, we're ripping out support for those deployments: #140, because this app is largely not well designed for those kinds of deployments.

So, we can remove that piece of logic, and just expect the user to make the credentials file available to the app (eg by mounting to the container), and just set the GOOGLE_APPLICATION_CREDENTIALS env var themselves.

Discussion: #143 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant