Use 'Numeric' instead of 'Float' as BQ column type when field type in the json schema is number #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the json schema is number (close #112)
istreeter
reviewed
Apr 27, 2023
There was a problem hiding this comment.
This looks great @voropaevp
I asked a couple of questions, which might let you remove a small amount of complexity, but not much. The implementation you've come up with is very simple and I like how the logic is shared between bigquery and parquet types.
Of course it's very important we test thoroughly before releasing it in a loader.
modules/core/src/main/scala/com.snowplowanalytics/iglu.schemaddl/bigquery/Type.scala
Show resolved
Hide resolved
Comment on lines
59
to
66
| case Some(CommonProperties.Type.Union(types)) if withNull(types, CommonProperties.Type.Number) => | ||
| schema.multipleOf match { | ||
| case Some(NumberProperty.MultipleOf.IntegerMultipleOf(_)) => | ||
| Some(name => Field(name, Type.fromGenericType(decimals.integerType(schema)), Mode.Nullable)) | ||
| case Some(mult: NumberProperty.MultipleOf.NumberMultipleOf) => | ||
| Some(name => Field(name, numericWithMultiple(mult, schema.maximum, schema.minimum), Mode.Nullable)) | ||
| case None => None | ||
| } |
There was a problem hiding this comment.
Could you remove this entire block starting from line 59, and let everything fall through to the next case on line 67?
There was a problem hiding this comment.
It won't fall though there, check the onlyNumeric implementation L180.
There was a problem hiding this comment.
Ah, I see. OK how about this then:
case Some(CommonProperties.Type.Union(types)) if withNull(types, CommonProperties.Type.Number) || onlyNumeric(types, true) =>
istreeter
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.