Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Twilio sent, delivered and queued SMS events #691

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

miike
Copy link
Contributor

@miike miike commented Jan 4, 2018

Replaces #688 #689 #690

@snowplowcla
Copy link

@miike has signed the Software Grant and Corporate Contributor License Agreement. Thanks so much

@alexanderdean
Copy link
Member

Thanks @miike! I think we have a Twilio account... Do you have some configuration instructions so we can QA these schemas?

@miike
Copy link
Contributor Author

miike commented Jan 4, 2018

Yes - will add this in tomorrow. What's the best way to share documentation relating to webhooks like this? Should there be a high level docs directory with Markdown READMEs?

@alexanderdean
Copy link
Member

Great stuff - ultimately the webhook setup guide will just go into the wiki like so:

https://github.com/snowplow/snowplow/wiki/Setting-up-a-Webhook

It's probably easiest just to add the setup guide to this thread first and we can port over later...

@miike
Copy link
Contributor Author

miike commented Jan 8, 2018

I've just had another look at the messaging service webhooks and it looks like I'll need to write a minimal adapter for this so that events don't all use the same schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants