Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-version support to get_field for bigquery #138

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

rlh1994
Copy link
Contributor

@rlh1994 rlh1994 commented Sep 12, 2023

Description & motivation

Add multi-version support to get_field for bigquery, just checking for an _* and coalesce across those. Need to update the readme still.

Checklist

  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

@rlh1994 rlh1994 force-pushed the feature/add_bq_to_get_field branch 2 times, most recently from 12b77f1 to 99eb15d Compare September 12, 2023 13:10
@rlh1994 rlh1994 marked this pull request as ready for review September 12, 2023 13:32
@rlh1994 rlh1994 requested a review from emielver as a code owner September 12, 2023 13:32
@rlh1994 rlh1994 force-pushed the feature/add_bq_to_get_field branch from 99eb15d to cd8b4a6 Compare September 12, 2023 16:04
Copy link
Contributor

@agnessnowplow agnessnowplow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the minor comments. I'm glad we support this for bigquery now here as well!

@rlh1994 rlh1994 force-pushed the feature/add_bq_to_get_field branch 3 times, most recently from 7be0fc3 to c5aaf23 Compare September 14, 2023 09:03
@rlh1994 rlh1994 force-pushed the feature/add_bq_to_get_field branch from c5aaf23 to c5594da Compare September 14, 2023 09:10
@rlh1994 rlh1994 merged commit 6d378b3 into release/snowplow-utils/0.15.0 Sep 14, 2023
4 checks passed
@rlh1994 rlh1994 deleted the feature/add_bq_to_get_field branch September 14, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants