Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-factor Ruby library #26

Closed
alexanderdean opened this issue May 21, 2013 · 1 comment
Closed

Re-factor Ruby library #26

alexanderdean opened this issue May 21, 2013 · 1 comment
Assignees
@alexanderdean
Labels
Ruby

Comments

@alexanderdean
Copy link
Contributor

Architecture is very OO and convoluted.

Move towards similar architecture to the Scala version: a Parser module which includes one-time instantiation, and then a static parse() method which returns a Referer object for a given URL.

@Tombar has moved it in the right direction with a public parse() method (Tombar@a280d9e).
@ghost ghost assigned alexanderdean May 21, 2013
@BenFradet
Copy link
Contributor

Migrated to snowplow-referer-parser/ruby-referer-parser#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderdean alexanderdean

Labels
Ruby
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexanderdean @BenFradet