SNOW-802269 Add regextract signum subindex collectlist functions #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added regexp_extract,signum,substring_index,collect_list 1) Added regexp_extract,signum,substring_index,collect_list to functions.scala . 2) Added test cases for the same * Added examples and updated the description * Fixed format * formatted the comments * Added java functions and unit test cases for java * Added sign function * Modified the alignment * Added examples * adjusted comments * Update Functions.java --------- Co-authored-by: sfc-gh-mrojas <[email protected]>
sfc-gh-sjayabalan
changed the title
|
Can you give it meaningful title? for example BTW, please reformat your code by |
sfc-gh-sjayabalan
changed the title
|
sfc-gh-bli
reviewed
Aug 15, 2024
| * --------- | ||
| * }</pr> | ||
| * | ||
| * @since 1.12.1 |
sfc-gh-bli
reviewed
Aug 15, 2024
| * ---------------------------------- | ||
| * }</pr> | ||
| * | ||
| * @since 1.12.1 |
sfc-gh-bli
reviewed
Aug 15, 2024
| * ---------------------------------- | ||
| * }</pr> | ||
| * | ||
| * @since 1.12.1 |
sfc-gh-bli
reviewed
Aug 15, 2024
| * count is negative, every to the right of the final delimiter (counting from the right) is | ||
| * returned. substring_index performs a case-sensitive match when searching for delim. | ||
| * | ||
| * @since 1.12.1 |
sfc-gh-bli
reviewed
Aug 15, 2024
| * "RESULT" [ 1, 2, 3 ] | ||
| * }</pre> | ||
| * | ||
| * @since 1.10.0 |
sfc-gh-bli
reviewed
Aug 15, 2024
| * --------- | ||
| *</pr> | ||
| * Note: non-greedy tokens such as are not supported | ||
| * @since 1.12.1 |
sfc-gh-bli
reviewed
Aug 15, 2024
| * |-1 |1 |0 | | ||
| * ---------------------------------- | ||
| * </pr> | ||
| * @since 1.12.1 |
sfc-gh-bli
reviewed
Aug 15, 2024
| * |-1 |1 |0 | | ||
| * ---------------------------------- | ||
| * </pr> | ||
| * @since 1.12.1 |
sfc-gh-bli
reviewed
Aug 15, 2024
| * NOTE: if string values are provided snowflake will attempts to cast. | ||
| * If it casts correctly, returns the calculation, | ||
| * if not an error will be thrown | ||
| * @since 1.12.1 |
sfc-gh-bli
reviewed
Aug 15, 2024
| * is returned. If count is negative, every to the right of the | ||
| * final delimiter (counting from the right) is returned. | ||
| * substring_index performs a case-sensitive match when searching for delim. | ||
| * @since 1.12.1 |
sfc-gh-bli
reviewed
Aug 15, 2024
| * |] | | ||
| * ------------ | ||
| * </pr> | ||
| * @since 1.10.0 |
sfc-gh-bli
reviewed
Aug 15, 2024
| * | 3 | | ||
| * |] | | ||
| * ------------ | ||
| * @since 1.10.0 |
sfc-gh-bli
reviewed
Aug 15, 2024
There was a problem hiding this comment.
1, please update all @since to 1.14.0, which is the next release.
2, Please check the merging gate, you have several tests failed.
3, Please verify your Java doc, that merging gate failed too. you can build java doc from your laptop via scripts/generateJavaDoc.sh.
…tract-signum-subindex-collectlist
…m-subindex-collectlist' of https://github.com/snowflakedb/snowpark-java-scala into sfc-gh-sjayabalansfc-gh-sjayabalan-sma-regextract-signum-subindex-collectlist
sfc-gh-sjayabalan
deleted the
sfc-gh-sjayabalansfc-gh-sjayabalan-sma-regextract-signum-subindex-collectlist
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added examples and updated the description
Fixed format
formatted the comments
Added java functions and unit test cases for java
Added sign function
Modified the alignment
Added examples
adjusted comments
Update Functions.java
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Replace this with a short description of how your code change solves the related issue.
Pre-review checklist
(For Snowflake employees)