From 120ea734a63d7d47316d0d41e669b1320c08e89a Mon Sep 17 00:00:00 2001 From: Arturo Herrera Aguilar Date: Mon, 4 Mar 2024 07:43:43 -0600 Subject: [PATCH] Update comments and rename param --- .../java/com/snowflake/snowpark_java/Functions.java | 6 +++--- .../scala/com/snowflake/snowpark/functions.scala | 12 +++++------- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/src/main/java/com/snowflake/snowpark_java/Functions.java b/src/main/java/com/snowflake/snowpark_java/Functions.java index 977205a6..45e3da55 100644 --- a/src/main/java/com/snowflake/snowpark_java/Functions.java +++ b/src/main/java/com/snowflake/snowpark_java/Functions.java @@ -377,11 +377,11 @@ public static Column sum(Column col) { * sum of unique non-null values. If all records inside a group are NULL, the function returns * NULL. * - * @since 0.9.0 - * @param str The input string + * @since 1.12.0 + * @param colName The input column name * @return The result column */ - public static Column sum(String str) { return sum(col(str)); } + public static Column sum(String colName) { return sum(col(colName)); } /** * Returns the sum of non-NULL distinct records in a group. You can use the DISTINCT keyword to diff --git a/src/main/scala/com/snowflake/snowpark/functions.scala b/src/main/scala/com/snowflake/snowpark/functions.scala index 83f55400..914bfb49 100644 --- a/src/main/scala/com/snowflake/snowpark/functions.scala +++ b/src/main/scala/com/snowflake/snowpark/functions.scala @@ -348,8 +348,7 @@ object functions { def stddev_pop(e: Column): Column = builtin("stddev_pop")(e) /** - * Returns the sum of non-NULL records in a group. You can use the DISTINCT keyword to compute - * the sum of unique non-null values. If all records inside a group are NULL, + * Returns the sum of non-NULL records in a group. If all records inside a group are NULL, * the function returns NULL. * * @group agg_func @@ -358,16 +357,15 @@ object functions { def sum(e: Column): Column = builtin("sum")(e) /** - * Returns the sum of non-NULL records in a group. You can use the DISTINCT keyword to compute - * the sum of unique non-null values. If all records inside a group are NULL, + * Returns the sum of non-NULL records in a group. If all records inside a group are NULL, * the function returns NULL. * * @group agg_func - * @since 0.1.0 - * @param e The input string + * @since 12.1.0 + * @param colName The input column name * @return The result column */ - def sum(e: String): Column = sum(col(e)) + def sum(colName: String): Column = sum(col(colName)) /** * Returns the sum of non-NULL distinct records in a group. You can use the DISTINCT keyword to