JDBC driver should not be shade/relocate Bouncycastle

[rafaelbey]

Bouncycastle libraries are signed as required by JCA.

Given the snowflake relocates the library, we are seeing failures on our applications if snowflake JDBC driver is loaded first (adding the BC provider).

While we have a workaround, this library should not be shaded/relocated or the jdbc driver should be properly signed.

[jdimeo]

More generally, can we make an unshaded .jar available for these use cases where we don't need a shaded jar? Something like:

<dependency>
    <groupId>net.snowflake</groupId>
    <artifactId>snowflake-jdbc</artifactId>
    <version>3.13.8</version>
    <classifier>unshaded</classifier>
</dependency>

[jdimeo]

This is more or less duplicate with #174

[rafaelbey]

That could do the trick.

Note that an unshaded jar could bring other challenges to large applications, with other libraries already competing for transitive library versions, like for Jackson among others. Hence, the unshaded would need to be kept lean as one of the proposals on #174 or could lead to other set of issues been raised.

[jdimeo]

Of course, but for those of us who are doing it the "Maven way" we are used to overriding transitive versions, etc. to resolve those kinds of conflicts. For AWS Lambdas with file size limits, it's important to allow users to have only one (for example) Jackson version if their use case allows it.

[joshuamzm]

It's unfortunate the Snowflake team hasn't resolved on this or #174 issues. However, I'm still having problems using the JDBC with other libraries depending on Bouncycastle.

@rafaelbey Can you elaborate more on your workaround to make your projects work along with the Snowflake JDBC driver?

In my case, I'm seeing this error, maybe because of the problem you described originally in this issue.

Exception in thread "main" java.lang.NoClassDefFoundError: net/snowflake/client/jdbc/internal/org/bouncycastle/crypto/CipherParameters (wrong name: org/bouncycastle/crypto/CipherParameters)

[wesleyhillyext]

I found this thread while investigating #1193.

Snowflake offers a FIPS-compliant version of their driver, which does not bundle Bouncy Castle in its JAR at all, see https://docs.snowflake.com/en/release-notes/2020-04.html#snowflake-jdbc-driver-fips-compliant-driver-released

I believe switching to that version of the driver will resolve the issue @rafaelbey had.

[sfc-gh-dszmolka]

hi folks - just a quick update; starting from version 3.14.5, we release the (for now, experimental) thin version of snowflake-jdbc (https://mvnrepository.com/artifact/net.snowflake/snowflake-jdbc-thin) which could solve problems like this.

if you have a possibility, test it please

[sfc-gh-dszmolka]

closing this issue as snowflake-jdbc-thin should solve this, and similar issues - if you have further concerns, do comment please and can reopen