-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-847342: Add connection property for setting browser timeout value #1824
SNOW-847342: Add connection property for setting browser timeout value #1824
Conversation
src/main/java/net/snowflake/client/core/SessionUtilExternalBrowser.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/jdbc/SnowflakeBasicDataSource.java
Outdated
Show resolved
Hide resolved
Test app: import java.sql.Connection; public class ExternalBrowserTest {
}` The test should launch an auth attempt in an external browser. If you then close the browser window you should now see an error being thrown within the browser timeout specified or 120 seconds by default Previously the driver would just hang infinitely. |
@sfc-gh-ext-simba-jf please include the sample as a manual test in JDBC |
I've added a manual test in ConnectionLatestIT. It can be run locally and will be ignored when running the test suite. If there is a better or preferred place to put this test, please let me know. |
Overview
SNOW-847342
Pre-review self checklist
master
branchmvn -P check-style validate
)mvn verify
and inspecttarget/japicmp/japicmp.html
)SNOW-XXXX:
External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi
(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
Added new connection property to allow setting a time out for external browser authentication.