Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1016468-Set-QueryID-For-all-exceptions #1737

Closed
wants to merge 54 commits into from
Closed

SNOW-1016468-Set-QueryID-For-all-exceptions #1737

wants to merge 54 commits into from

Conversation

sfc-gh-ext-simba-jf
Copy link
Collaborator

Overview

SNOW-1016468

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-ext-simba-jf sfc-gh-ext-simba-jf marked this pull request as ready for review April 25, 2024 15:08
@sfc-gh-ext-simba-jf sfc-gh-ext-simba-jf requested a review from a team as a code owner April 25, 2024 15:08
@sfc-gh-ext-simba-jf
Add queryid to all exceptions
1b2be14
@sfc-gh-ext-simba-jf
Merge branch 'SNOW-1016468-Set-Last-QueryID-For-All-Failed-Statements…
dc8a987 
…' of https://github.com/snowflakedb/snowflake-jdbc into SNOW-1016468-Set-Last-QueryID-For-All-Failed-Statements
@sfc-gh-ext-simba-jf
Add queryid to all exceptions
dbcb988
@sfc-gh-ext-simba-jf
Revert "Add queryid to all exceptions"
5e72cbe 
This reverts commit dbcb988.
@sfc-gh-ext-simba-jf
Revert "Add queryid to all exceptions"
8a68dcf 
This reverts commit 1b2be14.
@sfc-gh-ext-simba-jf
Revert "SNOW-1523813: Bump netty to the newest version (#1813)"
753a65e 
This reverts commit 823cecc.
@sfc-gh-ext-simba-jf
Revert "Prepare next development version (#1814)"
9c49e90 
This reverts commit f19866e.
@sfc-gh-ext-simba-jf
Revert "Bump version to 3.17.0 for release (#1812)"
27c90b6 
This reverts commit 356852c.
@sfc-gh-ext-simba-jf
Revert "SNOW-1369651: Do not fail file pattern expanding on file not …
17f1848 
…found in different pattern (#1811)"

This reverts commit f6548d5.
@sfc-gh-ext-simba-jf
Revert "SNOW-1514498 - support for host when use file configuration (#…
9db94f2 
…1809)"

This reverts commit 5f84023.
@sfc-gh-ext-simba-jf
Revert "SNOW-731500: Add JDBC Connectivity Diagnostics mode (#1789)"
7936c68 
This reverts commit 997002b.
@sfc-gh-ext-simba-jf
Revert "SNOW-1465374: Return consistent timestamps_ltz between JSON a…
1e2e4d3 
…nd ARROW result sets (#1792)"

This reverts commit 8e916ae.
@sfc-gh-ext-simba-jf
Revert " SNOW-1196082: FIx inserting and reading timestamps not symet…
768b4b9 
…ric if too much columns inserted with batch (#1794)"

This reverts commit 3fee6f9.
@sfc-gh-ext-simba-jf
Revert "SNOW-957747: Easy logging improvements (#1730)"
2e497a6 
This reverts commit f39eff4.
@sfc-gh-ext-simba-jf
Revert "SNOW-1163203: Increased Max LOB size in metadata (#1806)"
7f1dbb6 
This reverts commit d4504f8.
@sfc-gh-ext-simba-jf
Revert "SNOW-1490931: Preparation for Java 21 (#1796)"
65b371a 
This reverts commit a4db309.
@sfc-gh-ext-simba-jf
Revert "SNOW-1454054 - Read connection configuration from file. (#1780)"
ba035fd 
This reverts commit ccee1b1.
@sfc-gh-ext-simba-jf
Revert "SNOW-1495591: Support getObject on vector column (#1799)"
1205baa 
This reverts commit 6d11e4f.
@sfc-gh-ext-simba-jf
Revert "SNOW-1446174: Accept 513 next to 403 for OCSP tests (#1801)"
aa1f65b 
This reverts commit 66279ca.
@sfc-gh-ext-simba-jf
Revert "SNOW-1016467: Enable matrix for Azure and GCP cloud providers. (
f015a11 
#1777)"

This reverts commit ab4880c.
@sfc-gh-ext-simba-jf
Revert "SNOW-1016470: Increase code coverage in JDBC part1 (#1759)"
3e889be 
This reverts commit 184d6ff.
@sfc-gh-ext-simba-jf
Revert "SNOW-1488827: Fix SFTrustManagerIT tests (#1793)"
258174c 
This reverts commit 9f438a9.
@sfc-gh-ext-simba-jf
Revert "SNOW-1016467: Run tests on Windows in Github actions. (#1766)"
f7637f6 
This reverts commit 6a95dcc.
@sfc-gh-ext-simba-jf
Revert "SNOW-1452552: Expose vector dimension in column metadata (#1788…
01ae3f8 
…)"

This reverts commit 26fb3c6.
@sfc-gh-ext-simba-jf
Revert "SNOW-1016467: Fixed test to support execution on Windows (#1776…
be028ad 
…)"

This reverts commit e95bba2.
@sfc-gh-ext-simba-jf
Revert "SNOW-1017605: Improve logging (#1662)"
87f88aa 
This reverts commit 9b7c9eb.
@sfc-gh-ext-simba-jf
Revert "SNOW-1446174: Allow 513 and 404 in SFTrustManager tests (#1782)"
0441e71 
This reverts commit a79f58d.
@sfc-gh-ext-simba-jf
Revert "SNOW-1454594 Remove Shading of com.sun.* (#1775)"
f5c1398 
This reverts commit ac0e393.
@sfc-gh-ext-simba-jf
Revert "SNOW-1009500: Update PR template (#1772)"
cd35cf8 
This reverts commit d84639c.
@sfc-gh-ext-simba-jf
Revert "Prepare next development version (#1771)"
0f82b90 
This reverts commit 5242b83.
@sfc-gh-ext-simba-jf
Revert "Bump version to 3.16.1 for release (#1769)"
23cf626 
This reverts commit 573911d.
@sfc-gh-ext-simba-jf
Revert "SNOW-1446336: Use S3 regional url domain base on region name (#…
1ea9099 
…1768)"

This reverts commit 3c4b521.
@sfc-gh-ext-simba-jf
Revert "SNOW-1163212: Handle nested path on Windows in client config …
1125b24 
…parser (#1763)"

This reverts commit fb23408.
@sfc-gh-ext-simba-jf
Revert "SNOW-1416051: Fix getObject for array in json (#1761)"
c96a61f 
This reverts commit ffb87d7.
@sfc-gh-ext-simba-jf
Revert "SNOW-1308317 SNOW-1432770 Update DatabaseMetaDataInternalIT t…
9e43c10 
…estGetTables to work with adding account_usage_snowhouse_local_setup_import.sql to make setup (#1760)"

This reverts commit 23db457.
@sfc-gh-ext-simba-jf
Revert "SNOW-1226600: Add parameter to disable SAML URL check (#1748)"
db89170 
This reverts commit c601137.
@sfc-gh-ext-simba-jf
Revert "Fix MapVector casting issue (#1750)"
3ba0c22 
This reverts commit 18ae23d.
@sfc-gh-ext-simba-jf
Revert "SNOW-1356393: Fix flaky test EventHandlerTest.testEventFlusher (
6bcc567 
#1744)"

This reverts commit 72d9725.
@sfc-gh-ext-simba-jf
Revert "SNOW-1356389: Use junit assertions instead of jvm assert in t…
129fa88 
…ests (#1743)"

This reverts commit 9e1c486.
@sfc-gh-ext-simba-jf
Revert "Prepare next development version (#1742)"
6fbad8a 
This reverts commit 6f7a6b7.
@sfc-gh-ext-simba-jf
Revert "Bump version to 3.16.0 for release (#1741)"
790825f 
This reverts commit f12b25a.
@sfc-gh-ext-simba-jf
Revert "SNOW-1333078: Add explicitly surefire autodetected dependenci…
c55c5b6 
…es (#1739)"

This reverts commit 2da252d.
@sfc-gh-ext-simba-jf
Revert "SNOW-1045676: Fix list of reserved keywords (#1670)"
72806d4 
This reverts commit 6927fff.
@sfc-gh-ext-simba-jf
Revert "Structured types backward compatibility for getObject method (#…
c95d699 
…1740)"

This reverts commit ed334e6.
@sfc-gh-ext-simba-jf
Revert "SNOW-1213117: Wrap connection, statement and result set in tr…
e6c065a 
…y with resources(4/4) (#1724)"

This reverts commit ff0adbd.
@sfc-gh-ext-simba-jf
Revert "SNOW-1213117: Wrap connection, statement and result set in tr…
e4d6930 
…y with resources(2/4) (#1722)"

This reverts commit 7cb73ff.
@sfc-gh-ext-simba-jf
Revert "SNOW-1157904 write and bindings structured types (#1727)"
efea0fb 
This reverts commit 8dcd217.
@sfc-gh-ext-simba-jf
Revert "SNOW-1213117: Wrap connection, statement and result set in tr…
e79cf10 
…y with resources(3/4) (#1723)"

This reverts commit 804ef67.
@sfc-gh-ext-simba-jf
Add queryid to all exceptions
af365dc
@sfc-gh-ext-simba-jf
Refactored and deprected some constructors
bd47006
sfc-gh-dprzybysz
sfc-gh-dprzybysz approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-dprzybysz sfc-gh-dprzybysz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes look good but should we really have 98 commits in this PR? is this PR up to date with the master branch?

@sfc-gh-ext-simba-jf
Copy link
Collaborator Author

sfc-gh-ext-simba-jf commented Jul 16, 2024 •
edited
Loading

The changes are up to date, the commit messages are a result of a rebasing mishap. I tried to revert all the commits the rebase pulled in as one commit, but it wasn't working so I had to individually revert the commits and then merge master to avoid having all the files pulled into this PR.

I'm currently fixing the test failures

@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-1016468-Set-Last-QueryID-For-All-Failed-Statements branch July 18, 2024 07:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-ext-simba-jf @sfc-gh-dprzybysz