Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1168175: Tiny bug: Link to Release notes in CHANGELOG is outdated #1652

Closed
BI-MarcB opened this issue Feb 28, 2024 · 3 comments
Closed

SNOW-1168175: Tiny bug: Link to Release notes in CHANGELOG is outdated #1652

BI-MarcB opened this issue Feb 28, 2024 · 3 comments
Assignees
@sfc-gh-sghosh
Labels
status-triage_done Initial triage done, will be further handled by the driver team

Comments

@BI-MarcB
Copy link

BI-MarcB commented Feb 28, 2024 •
edited
Loading

https://github.com/snowflakedb/snowflake-jdbc/blob/master/CHANGELOG.rst contains a link to https://community.snowflake.com/s/article/JDBC-Driver-Release-Notes. On this page, it says that the page itself was deprecated in Sept. 2023 and the new links are https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc-2023 for 2023 and https://docs.snowflake.com/en/release-notes/clients-drivers/jdbc-2024 for 2024.

Therefore, CHANGELOG.rst should be adjusted to point to the new change log location going forward.
@BI-MarcB BI-MarcB added the bug label Feb 28, 2024
@github-actions github-actions bot changed the title Tiny bug: Link to Release notes in CHANGELOG is outdated SNOW-1168175: Tiny bug: Link to Release notes in CHANGELOG is outdated Feb 28, 2024
@sfc-gh-sghosh sfc-gh-sghosh self-assigned this Mar 4, 2024
@sfc-gh-sghosh sfc-gh-sghosh added status-triage Issue is under initial triage and removed bug labels Mar 4, 2024
@sfc-gh-sghosh
Copy link
Contributor

Hello @BI-MarcB ,

Thanks for raising the issue, we're taking a look, will update the CHANGELOG with updated links.

Regards,
Sujan

@sfc-gh-sghosh
Copy link
Contributor

Hello @BI-MarcB ,

I have created a PR (#1668)

Regards,
Sujan

@sfc-gh-sghosh sfc-gh-sghosh added status-triage_done Initial triage done, will be further handled by the driver team status-pr_pending_merge A PR is made and is under review and removed status-triage Issue is under initial triage labels Mar 11, 2024
@sfc-gh-sghosh
Copy link
Contributor

Hello @BI-MarcB ,

The changes has been merged and delivered.

Regards,
Sujan

@sfc-gh-sghosh sfc-gh-sghosh removed the status-pr_pending_merge A PR is made and is under review label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfc-gh-sghosh sfc-gh-sghosh

Labels
status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sfc-gh-dszmolka @sfc-gh-sghosh @BI-MarcB