SNOW-1042432: Remove dependency on com.amazonaws.Protocol from HttpClientSettingsKey #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
jtjeferreira
force-pushed
the
remove_dependecy_on_protocol
branch
from
86e5934 to
55a94fb
Compare
|
I have read the CLA Document and I hereby sign the CLA |
sfc-gh-dprzybysz
requested changes
Feb 5, 2024
src/main/java/net/snowflake/client/core/HttpClientSettingsKey.java
Outdated
Show resolved
Hide resolved
jtjeferreira
force-pushed
the
remove_dependecy_on_protocol
branch
from
55a94fb to
7ca3a88
Compare
sfc-gh-dprzybysz
requested changes
Feb 6, 2024
src/main/java/net/snowflake/client/core/HttpClientSettingsKey.java
Outdated
Show resolved
Hide resolved
sfc-gh-dprzybysz
requested changes
Feb 7, 2024
src/main/java/net/snowflake/client/core/HttpClientSettingsKey.java
Outdated
Show resolved
Hide resolved
…tocol().getScheme() instead
setSessionlessProxyForS3 was also moved because the methods are related
…s not use com.amazonaws.Protocol
sfc-gh-dprzybysz
requested changes
Feb 8, 2024
src/main/java/net/snowflake/client/core/SnowflakeMutableProxyRoutePlanner.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/SnowflakeMutableProxyRoutePlanner.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/SnowflakeMutableProxyRoutePlanner.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/HttpClientSettingsKey.java
Outdated
Show resolved
Hide resolved
… but does not use com.amazonaws.Protocol" This reverts commit aaa5ca3.
|
Because of security reasons we cannot run build on your PR directly. There is a copy of your code in #1633 - note that it means that when you change anything in your branch we will need to manually update the draft PR to have actual jobs results You can check that there is one small formatting problem - please fix it with There is also one one comment left unsolved Please also remember to rebase to current master |
sfc-gh-dprzybysz
requested changes
Feb 13, 2024
sfc-gh-dprzybysz
approved these changes
Feb 14, 2024
sfc-gh-dprzybysz
changed the title
|
Thank you @jtjeferreira for the contribution, the change will be included in the next release of snowflake-jdbc |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1042432: Do not use com.amazonaws classes in core SF classes #1626
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Removes dependency on
com.amazonaws.ProtocolfromHttpClientSettingsKey.There are still a few other references to
com.amazonawsclasses, so I am not sure this completely fixes #1626. I also do not know what would be the best way to tests this or prevent dependencies like this to be added in the future...Pre-review checklist