Add tests for max LOB size #1623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| protected static String jsonQueryResultFormat = "json"; | ||
|
|
||
| //TODO: increase max size to 128 * 1024 * 1024 | ||
| public static int maxLobSize = 16 * 1024 * 1024; |
There was a problem hiding this comment.
please prefer private than public for fields
|
|
||
| public static Connection getConnection() throws SQLException { | ||
| Connection con = BaseJDBCTest.getConnection(); | ||
| Statement stmt = con.createStatement(); |
There was a problem hiding this comment.
let's use try-with-resources in all the places where it is possible
| return con; | ||
| } | ||
|
|
||
| public static void setJSONResultFormat(Connection con) throws SQLException { |
There was a problem hiding this comment.
those non-test methods should be private?
| pstmt.close(); | ||
| } | ||
| @Test | ||
| public void testSmallLobSize() throws SQLException { |
There was a problem hiding this comment.
let's make those tests parameterized with the size of the lob and just comment out or ignore not supported yet entries
…ientSettingsKey (#1627)
…if pattern searches for some DatabaseMetaData methods are allowed (#1639)
…orCodeChangeOnAsyncQuery (#1644)
#1624) * SNOW-970859 Implement getObject for structured types for JSON response * SNOW-974576 Create FieldsMetadata * SNOW-974576 Add JsonConverters in ArrowResultSet for struct --------- Co-authored-by: Przemyslaw Motacki <[email protected]>
…owflake-jdbc into max-lob-size-test
|
This branch got messed up when I was trying to commit my latest changes. For simplicity I've opened a new PR here #1653 and will close this one to not add clutter. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-XXXXX
External contributors - please answer these questions before submitting a pull request. Thanks!
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
Pre-review checklist