SNOW-997216 Init serverDeployment to default value

[sfc-gh-pfus]

Overview

SNOW-997216 When using upload without connection the OOB telemetry is not initialized properly - server deployment is not set. Now we set it to PROD by default.

[sfc-gh-dstempniak]

@sfc-gh-pfus please fill the description

[sonarqubemergegate]

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[sfc-gh-japatel]

For my under, How does this fix help? We have only seem intermittent failures!

[sfc-gh-japatel]

Can you also add test?

[sfc-gh-pfus]

Hi @sfc-gh-japatel ! The fix was tested and confirmed by @sfc-gh-hachouraria . The problem is that serverDeployment field is initialized during first connection. Ingest SDK uses connectionless mode, so this field is never set. Without connection we don't know which environment it uses, so we have to guess and the most likely it is production. I also suggested testing setting this field manually, awaiting Harsh test.

About the test, unfortunately we can't have a test without any connection. The test setup itself creates the connections. Also, it may be difficult to mimic S3 error in integration test.

[sfc-gh-japatel]

Thanks @sfc-gh-pfus for response!

[sfc-gh-xhuang]

@sfc-gh-pfus can this be merged and released along with the GCP fix this week?

[sfc-gh-pfus]

@sfc-gh-xhuang merged!