SNOW-965966: Remove unnecessary TODOs from DefaultResultStreamProvider

[sfc-gh-ext-simba-jf]

Overview

SNOW-965966 Move http client creation to HttpUtil class from DefaultResultStreamProvider

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

   Fixes

2. Fill out the following pre-review checklist:

   • I am adding a new automated test(s) to verify correctness of my new code
   • I am adding new logging messages
   • I am modifying authorization mechanisms
   • I am adding new credentials
   • I am modifying OCSP code
   • I am adding a new dependency

3. Please describe how your code solves the related issue.

   Moved the http client creation out of DefaultResultStreamProvider

Pre-review checklist

• This change has passed precommit
• I have reviewed code coverage report for my PR in (Sonarqube)

[sonarqubemergegate]

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[sfc-gh-pfus]

Hi @sfc-gh-ext-simba-jf ! I have a couple of questions here:

1. What is the main change here? By looking at the code I can see that this is only a bit of refactoring, we use the same HttpClient retrieved from HttpUtil etc. I'm certainly missing the root change.
2. How did you test it? I see no change in tests, so maybe you can describe in the PR description what manual tests you performed?

[sfc-gh-ext-simba-jf]

Hi @sfc-gh-pfus, the request for this ticket was basically just to refactor the code to utilize the connection pool manager initialized by the HttpUtil class. For testing I used the hang_webserver as well as the existing IT and unit tests.