Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-887071 : Added connection property to disable PUT/GET command #1523

Merged
merged 3 commits into from
Oct 5, 2023
Merged

SNOW-887071 : Added connection property to disable PUT/GET command #1523

merged 3 commits into from
Oct 5, 2023

Conversation

sfc-gh-igarish
Copy link
Collaborator

Overview

SNOW-887071

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Pre-review checklist

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-igarish sfc-gh-igarish requested a review from a team as a code owner October 4, 2023 04:30
@sfc-gh-igarish
Copy link
Collaborator Author

I will add test in another commit.

sfc-gh-skumbham
sfc-gh-skumbham approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@sfc-gh-skumbham sfc-gh-skumbham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubemergegate
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sfc-gh-igarish sfc-gh-igarish merged commit c997f9a into master Oct 5, 2023
12 checks passed
@sfc-gh-igarish sfc-gh-igarish deleted the igarish-SNOW-887071-disable-put-get-command branch October 5, 2023 05:36
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2023
@sfc-gh-igarish sfc-gh-igarish restored the igarish-SNOW-887071-disable-put-get-command branch October 5, 2023 05:48
sfc-gh-skumbham
sfc-gh-skumbham reviewed Oct 5, 2023
View reviewed changes
src/test/java/net/snowflake/client/jdbc/SnowflakeDriverLatestIT.java

statement.execute("PUT file://" + sourceFilePathOriginal + " @testPutGet_disable_stage");

assertTrue("Shouldn't come here", false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assert.Fail is more appropriate here

sfc-gh-skumbham
sfc-gh-skumbham reviewed Oct 5, 2023
View reviewed changes
src/test/java/net/snowflake/client/jdbc/SnowflakeDriverLatestIT.java
statement.execute(
"GET @testPutGet_disable_stage 'file://" + destFolderCanonicalPath + "' parallel=8");

assertTrue("Shouldn't come here", false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@sfc-gh-igarish sfc-gh-igarish self-assigned this Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-skumbham sfc-gh-skumbham sfc-gh-skumbham approved these changes

Assignees

@sfc-gh-igarish sfc-gh-igarish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-igarish @sfc-gh-skumbham