Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback method for opening external browser #1509

Closed
wants to merge 1 commit into from

Conversation

RobbertDM
Copy link

@RobbertDM RobbertDM commented Sep 6, 2023

Overview

SNOW-906821

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #1505

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Pre-review checklist

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@RobbertDM RobbertDM requested a review from a team as a code owner September 6, 2023 11:38
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@RobbertDM
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@RobbertDM
Copy link
Author

recheck

@RobbertDM
Copy link
Author

@sfc-gh-japatel @sfc-gh-igarish @sfc-gh-pfus Just tagging the last 3 committers on the repo. What is the process for getting this merged?

@sfc-gh-igarish
Copy link
Collaborator

@RobbertDM Because it uses OS level system function, which can cause to run any injected code in the sslURL, we need to go through the security review.

@sfc-gh-dprzybysz
Copy link
Collaborator

The original issue is closed and we can close this PR also

@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNOW-906821: The BROWSE action is not supported on the current platform!
3 participants