Return reasonable values from java.sql.DatabaseMetaData API methods. #1417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-XXXXX
External contributors - please answer these questions before submitting a pull request. Thanks!
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes Should not throw exceptions from certain methods in net.snowflake.client.jdbc.SnowflakeDatabaseMetaData #1416
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
The reasons for this is detailed in the issue description
The net.snowflake.client.jdbc.SnowflakeDatabaseMetaData class throws SnowflakeLoggedFeatureNotSupportedException from certain JDBC methods. Throwing those exceptions causes cascading failures in frameworks that depend on JDBC drivers (e.g. Hibernate). Exceptions should only be thrown from those methods in the case of database access errors (per the java.sql.DatabaseMetaData API). For most of those methods a reasonable value should be returned and exceptions should only be thrown if/when unsupported features are used as opposed to throwing them in methods which simply describe the driver.
The two methods that cause the currently observed failure are:
net.snowflake.client.jdbc.SnowflakeDatabaseMetaData.getSQLStateType()
net.snowflake.client.jdbc.SnowflakeDatabaseMetaData.locatorsUpdateCopy()
Retuning the constant java.sql.DatabaseMetaData.sqlStateSQL from getSQLStateType() appears to work fine, and returning false from locatorsUpdateCopy() works as well.
The same principle should be followed for any other java.sql.DatabaseMetaData methods which describe features, to prevent similar issues in other frameworks.
Pre-review checklist