Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-832603: update the JDBC test case for structure types with the consolidated parameter #1413

Closed
wants to merge 2 commits into from
Closed

SNOW-832603: update the JDBC test case for structure types with the consolidated parameter #1413

wants to merge 2 commits into from

Conversation

sfc-gh-zpeng
Copy link
Contributor

Overview

SNOW-832603

The old parameters have been replaced with one consolidated parameter.

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Pre-review checklist

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-zpeng sfc-gh-zpeng requested a review from a team as a code owner June 9, 2023 22:42
@sfc-gh-zpeng
Copy link
Contributor Author

@sfc-gh-bchen
@sfc-gh-hchaturvedi

Could you review this?

sfc-gh-bchen
sfc-gh-bchen approved these changes Jun 10, 2023
View reviewed changes
Copy link

@sfc-gh-bchen sfc-gh-bchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

sfc-gh-hchaturvedi
sfc-gh-hchaturvedi approved these changes Jun 12, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-hchaturvedi sfc-gh-hchaturvedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-zpeng
Copy link
Contributor Author

I can't merge this because of the gates, and I can't re-run the gates...

@sfc-gh-igarish
Copy link
Collaborator

Already changed in latest code. Please check.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-bchen sfc-gh-bchen sfc-gh-bchen approved these changes

@sfc-gh-hchaturvedi sfc-gh-hchaturvedi sfc-gh-hchaturvedi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-zpeng @sfc-gh-igarish @sfc-gh-hchaturvedi @sfc-gh-bchen