From 5e99b2c0c248b78af36e6be78f5afa84c1eebb85 Mon Sep 17 00:00:00 2001 From: Jelena Furundzic Date: Tue, 5 Nov 2024 22:42:24 -0800 Subject: [PATCH] code review changes --- .../net/snowflake/client/core/QueryContextCache.java | 2 +- .../java/net/snowflake/client/core/ResultUtil.java | 2 +- .../java/net/snowflake/client/core/SFBaseSession.java | 10 +++++----- .../net/snowflake/client/core/SFBaseStatement.java | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/main/java/net/snowflake/client/core/QueryContextCache.java b/src/main/java/net/snowflake/client/core/QueryContextCache.java index 8e894b0f0..60cd8501a 100644 --- a/src/main/java/net/snowflake/client/core/QueryContextCache.java +++ b/src/main/java/net/snowflake/client/core/QueryContextCache.java @@ -338,7 +338,7 @@ private static QueryContextElement deserializeQueryContextElementDTO( * Serialize the QueryContext cache to a QueryContextDTO object, which can be serialized to JSON * automatically later. * - * @return QueryContextDTO {@link QueryContextDTO} + * @return {@link QueryContextDTO} */ public QueryContextDTO serializeQueryContextDTO() { synchronized (this) { diff --git a/src/main/java/net/snowflake/client/core/ResultUtil.java b/src/main/java/net/snowflake/client/core/ResultUtil.java index 2bd6c462d..20acee866 100644 --- a/src/main/java/net/snowflake/client/core/ResultUtil.java +++ b/src/main/java/net/snowflake/client/core/ResultUtil.java @@ -88,7 +88,7 @@ public static Object effectiveParamValue(Map parameters, String * @param id id * @param param timestamp output format param * @param defaultFormat default format - * @return SnowflakeDateTimeFormat {@link SnowflakeDateTimeFormat} + * @return {@link SnowflakeDateTimeFormat} */ public static SnowflakeDateTimeFormat specializedFormatter( Map parameters, String id, String param, String defaultFormat) { diff --git a/src/main/java/net/snowflake/client/core/SFBaseSession.java b/src/main/java/net/snowflake/client/core/SFBaseSession.java index bbec45acf..9222b4a57 100644 --- a/src/main/java/net/snowflake/client/core/SFBaseSession.java +++ b/src/main/java/net/snowflake/client/core/SFBaseSession.java @@ -334,7 +334,7 @@ public void setInjectFileUploadFailure(String fileToFail) { * * @see CLIENT_TIMESTAMP_TYPE_MAPPING - * @return SnowflakeType {@link SnowflakeType} + * @return {@link SnowflakeType} */ public SnowflakeType getTimestampMappedType() { return timestampMappedType; @@ -709,7 +709,7 @@ public void unsetInvalidProxyHostAndPort() { /** * Get OCSP mode * - * @return OCSPMode {@link OCSPMode} + * @return {@link OCSPMode} */ public OCSPMode getOCSPMode() { OCSPMode ret; @@ -812,7 +812,7 @@ public void setMetadataRequestUseConnectionCtx(boolean enabled) { /** * Get injected delay * - * @return AtomicInteger {@link AtomicInteger} + * @return {@link AtomicInteger} */ AtomicInteger getInjectedDelay() { return _injectedDelay; @@ -1260,7 +1260,7 @@ public void clearSqlWarnings() { /** * Get the SFConnectionHandler * - * @return SFConnectionHandler {@link SFConnectionHandler} + * @return {@link SFConnectionHandler} */ public SFConnectionHandler getSfConnectionHandler() { return sfConnectionHandler; @@ -1284,7 +1284,7 @@ public SFConnectionHandler getSfConnectionHandler() { public abstract int getMaxHttpRetries(); /** - * @return SnowflakeConnectString {@link SnowflakeConnectString} + * @return {@link SnowflakeConnectString} */ public abstract SnowflakeConnectString getSnowflakeConnectionString(); diff --git a/src/main/java/net/snowflake/client/core/SFBaseStatement.java b/src/main/java/net/snowflake/client/core/SFBaseStatement.java index 052cbf6b0..104d49387 100644 --- a/src/main/java/net/snowflake/client/core/SFBaseStatement.java +++ b/src/main/java/net/snowflake/client/core/SFBaseStatement.java @@ -191,7 +191,7 @@ public static boolean isFileTransfer(String sql) { * Retrieves the current result as a ResultSet, if any. This is invoked by SnowflakeStatement and * should return an SFBaseResultSet, which is then wrapped in a SnowflakeResultSet. * - * @return SFBaseResultSet {@link SFBaseResultSet} + * @return {@link SFBaseResultSet} */ public abstract SFBaseResultSet getResultSet();