From 5d0ed00acfa08f1b09418ce4ed299c9908776b63 Mon Sep 17 00:00:00 2001
From: Dawid Heyman <dawid.heyman@snowflake.com>
Date: Thu, 21 Mar 2024 15:18:15 +0100
Subject: [PATCH] CR suggestions

---
 src/main/java/net/snowflake/client/jdbc/SnowflakeType.java      | 2 +-
 src/test/java/net/snowflake/client/AbstractDriverIT.java        | 1 +
 .../snowflake/client/jdbc/ResultSetStructuredTypesLatestIT.java | 2 ++
 3 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/main/java/net/snowflake/client/jdbc/SnowflakeType.java b/src/main/java/net/snowflake/client/jdbc/SnowflakeType.java
index 9dcaccb06..ef4406d5f 100644
--- a/src/main/java/net/snowflake/client/jdbc/SnowflakeType.java
+++ b/src/main/java/net/snowflake/client/jdbc/SnowflakeType.java
@@ -53,7 +53,7 @@ public static SnowflakeType fromString(String name) {
   }
 
   public static JavaDataType getJavaType(SnowflakeType type) {
-    // TODO structuredType fill for Array and Map
+    // TODO structuredType fill for Array and Map: SNOW-1234216, SNOW-1234214
     switch (type) {
       case TEXT:
         return JavaDataType.JAVA_STRING;
diff --git a/src/test/java/net/snowflake/client/AbstractDriverIT.java b/src/test/java/net/snowflake/client/AbstractDriverIT.java
index 5a2979e71..b44cc31ef 100644
--- a/src/test/java/net/snowflake/client/AbstractDriverIT.java
+++ b/src/test/java/net/snowflake/client/AbstractDriverIT.java
@@ -323,6 +323,7 @@ public static Connection getConnection(
     properties.put("ssl", params.get("ssl"));
 
     properties.put("internal", Boolean.TRUE.toString()); // TODO: do we need this?
+    properties.put("insecureMode", false); // use OCSP for all tests.
 
     if (injectSocketTimeout > 0) {
       properties.put("injectSocketTimeout", String.valueOf(injectSocketTimeout));
diff --git a/src/test/java/net/snowflake/client/jdbc/ResultSetStructuredTypesLatestIT.java b/src/test/java/net/snowflake/client/jdbc/ResultSetStructuredTypesLatestIT.java
index eba0187c4..20b769f2c 100644
--- a/src/test/java/net/snowflake/client/jdbc/ResultSetStructuredTypesLatestIT.java
+++ b/src/test/java/net/snowflake/client/jdbc/ResultSetStructuredTypesLatestIT.java
@@ -24,6 +24,7 @@
 import net.snowflake.client.RunningOnGithubAction;
 import net.snowflake.client.ThrowingConsumer;
 import net.snowflake.client.category.TestCategoryStructuredType;
+import net.snowflake.client.core.SnowflakeJdbcInternalApi;
 import net.snowflake.client.core.structs.SnowflakeObjectTypeFactories;
 import org.junit.Assume;
 import org.junit.Before;
@@ -438,6 +439,7 @@ private void withFirstRow(String sqlText, ThrowingConsumer<ResultSet, SQLExcepti
     }
   }
 
+  @SnowflakeJdbcInternalApi
   enum ResultSetFormatType {
     JSON("JSON"),
     ARROW_WITH_JSON_STRUCTURED_TYPES("ARROW"),