From 3e75af272e15eeabcb6530a9084510653d73aee1 Mon Sep 17 00:00:00 2001
From: Hitesh Madan <hitesh.madan@snowflake.com>
Date: Fri, 25 Oct 2024 02:47:06 +0000
Subject: [PATCH] pr comments

---
 .../snowflake/ingest/streaming/internal/IStorageManager.java | 5 +++--
 .../ingest/streaming/internal/SnowflakeServiceClient.java    | 2 +-
 src/main/java/net/snowflake/ingest/utils/Constants.java      | 2 +-
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/main/java/net/snowflake/ingest/streaming/internal/IStorageManager.java b/src/main/java/net/snowflake/ingest/streaming/internal/IStorageManager.java
index 2ee9f9df0..34c1c9102 100644
--- a/src/main/java/net/snowflake/ingest/streaming/internal/IStorageManager.java
+++ b/src/main/java/net/snowflake/ingest/streaming/internal/IStorageManager.java
@@ -48,8 +48,9 @@ interface IStorageManager {
   /**
    * Get the updated subscoped tokens and location info for this table
    *
-   * @param tableRef
-   * @param fileName
+   * @param tableRef The table for which to get the location
+   * @param fileName Legacy, was used by deprecated GCS codepaths when it didn't support subscoped
+   *     tokens. Not in use.
    * @return
    */
   FileLocationInfo getRefreshedLocation(TableRef tableRef, Optional<String> fileName);
diff --git a/src/main/java/net/snowflake/ingest/streaming/internal/SnowflakeServiceClient.java b/src/main/java/net/snowflake/ingest/streaming/internal/SnowflakeServiceClient.java
index 41c803689..918c0a7f4 100644
--- a/src/main/java/net/snowflake/ingest/streaming/internal/SnowflakeServiceClient.java
+++ b/src/main/java/net/snowflake/ingest/streaming/internal/SnowflakeServiceClient.java
@@ -99,7 +99,7 @@ GeneratePresignedUrlsResponse generatePresignedUrls(GeneratePresignedUrlsRequest
     return response;
   }
 
-  /** Generates a batch of presigned URLs for a table */
+  /** Fetches the latest sub-scoped tokens from the server for the requested table in the request */
   RefreshTableInformationResponse refreshTableInformation(RefreshTableInformationRequest request)
       throws IngestResponseException, IOException {
     RefreshTableInformationResponse response =
diff --git a/src/main/java/net/snowflake/ingest/utils/Constants.java b/src/main/java/net/snowflake/ingest/utils/Constants.java
index 0a5fc673c..754c81cff 100644
--- a/src/main/java/net/snowflake/ingest/utils/Constants.java
+++ b/src/main/java/net/snowflake/ingest/utils/Constants.java
@@ -49,7 +49,7 @@ public class Constants {
   public static final int BLOB_FILE_SIZE_SIZE_IN_BYTES = 8;
   public static final int BLOB_CHECKSUM_SIZE_IN_BYTES = 8;
   public static final int BLOB_CHUNK_METADATA_LENGTH_SIZE_IN_BYTES = 4;
-  public static final long THREAD_SHUTDOWN_TIMEOUT_IN_SEC = 30L;
+  public static final long THREAD_SHUTDOWN_TIMEOUT_IN_SEC = 300L;
   public static final String BLOB_EXTENSION_TYPE = "bdec";
   public static final int MAX_THREAD_COUNT = Integer.MAX_VALUE;
   public static final String CLIENT_CONFIGURE_ENDPOINT = "/v1/streaming/client/configure/";