Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support base64-encoded DER private keys #2134

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Support base64-encoded DER private keys #2134

merged 3 commits into from
Jan 13, 2025
+23 −5

Conversation

sfc-gh-eworoshow
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes Support base64-encoded DER private keys #2133

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Support base64-encoded DER private keys. We currently support raw DER bytes, and now we will also support base64-encoded DER strings. This functionality is useful for passing private keys through environment variables and other configuration mechanisms.

  4. (Optional) PR for stored-proc connector:

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 13, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@sfc-gh-eworoshow
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA.

sfc-gh-kjudung
sfc-gh-kjudung approved these changes Jan 13, 2025
View reviewed changes
Copy link

@sfc-gh-kjudung sfc-gh-kjudung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sfc-gh-mkeller
sfc-gh-mkeller approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢

@sfc-gh-mkeller
Copy link
Collaborator

Please add a changelog entry before merging the PR

@sfc-gh-mkeller sfc-gh-mkeller added the DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector label Jan 13, 2025
@sfc-gh-eworoshow sfc-gh-eworoshow enabled auto-merge (squash) January 13, 2025 21:42
@sfc-gh-eworoshow sfc-gh-eworoshow merged commit 4b3ded1 into main Jan 13, 2025
89 of 92 checks passed
@sfc-gh-eworoshow sfc-gh-eworoshow deleted the eworoshow-b64-key-pair branch January 13, 2025 22:33
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pmansour sfc-gh-pmansour sfc-gh-pmansour approved these changes

@sfc-gh-xizhao sfc-gh-xizhao sfc-gh-xizhao approved these changes

@sfc-gh-ncaspi sfc-gh-ncaspi sfc-gh-ncaspi approved these changes

@sfc-gh-kjudung sfc-gh-kjudung sfc-gh-kjudung approved these changes

@sfc-gh-mkeller sfc-gh-mkeller sfc-gh-mkeller approved these changes

Assignees
No one assigned
Labels
DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support base64-encoded DER private keys
6 participants
@sfc-gh-eworoshow @sfc-gh-mkeller @sfc-gh-kjudung @sfc-gh-ncaspi @sfc-gh-xizhao @sfc-gh-pmansour