Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1789663: Resolve @aws-sdk/[email protected] NPM deprecation warning #947

Closed
dar-yl opened this issue Nov 6, 2024 · 6 comments
Closed

SNOW-1789663: Resolve @aws-sdk/[email protected] NPM deprecation warning #947

dar-yl opened this issue Nov 6, 2024 · 6 comments
Assignees
@sfc-gh-dszmolka
Labels
status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. status-triage_done Initial triage done, will be further handled by the driver team

Comments

@dar-yl
Copy link

dar-yl commented Nov 6, 2024 •
edited
Loading

Related - @azure/[email protected] deprecation: #948

  1. What version of NodeJS driver are you using?
    1.14.0

  2. What operating system and processor architecture are you using?
    N/A

  3. What version of NodeJS are you using?
    Node: 20.17.0 / NPM: 10.8.2

  4. What are the component versions in the environment (npm list)?

    [email protected]
└── [email protected]

  5. What did you do?
    Install the Node [email protected]. Refer to NPM deprecation warnings...

    npm i [email protected]
npm warn deprecated @aws-sdk/[email protected]: This package has moved to @smithy/node-http-handler
# ...

  6. What did you expect to see?
    No deprecation warnings.

  7. Can you collect debug logs?
    N/A
@dar-yl dar-yl added the bug Something isn't working label Nov 6, 2024
@github-actions github-actions bot changed the title Resolve @azure/[email protected] NPM deprecation warning SNOW-1789663: Resolve @azure/[email protected] NPM deprecation warning Nov 6, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka changed the title SNOW-1789663: Resolve @azure/[email protected] NPM deprecation warning SNOW-1789663: Resolve @aws-sdk/[email protected] NPM deprecation warning Nov 6, 2024
@sfc-gh-dszmolka
Copy link
Collaborator

hi - thank you for drawing attention to this, not entirely sure why we need 2 separate issues but works for us. we'll look into this.

@sfc-gh-dszmolka sfc-gh-dszmolka added status-triage_done Initial triage done, will be further handled by the driver team and removed bug Something isn't working labels Nov 6, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka self-assigned this Nov 6, 2024
@dar-yl
Copy link
Author

dar-yl commented Nov 6, 2024 •
edited
Loading

@sfc-gh-dszmolka thanks and no worries - I wasn't sure how you'd prefer to approach it, figured the safer default was to split the issues.
Happy to merge the 2 if you would prefer.

@dar-yl dar-yl mentioned this issue Nov 6, 2024
Open
@sfc-gh-dszmolka
Copy link
Collaborator

no worries , let's keep them separate for now, in case any issue with the dependency bump

@sfc-gh-dszmolka sfc-gh-dszmolka added the status-in_progress Issue is worked on by the driver team label Nov 7, 2024
@sfc-gh-dszmolka
Copy link
Collaborator

PR in draft #950

@sfc-gh-dszmolka sfc-gh-dszmolka added status-pr_pending_merge A PR is made and is under review status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. and removed status-in_progress Issue is worked on by the driver team status-pr_pending_merge A PR is made and is under review labels Nov 7, 2024
@sfc-gh-dszmolka
Copy link
Collaborator

PR merged, and will be part of the next version

@sfc-gh-dszmolka sfc-gh-dszmolka mentioned this issue Nov 20, 2024
Closed
5 tasks
@sfc-gh-dszmolka
Copy link
Collaborator

released with Snowflake Node.js driver v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfc-gh-dszmolka sfc-gh-dszmolka

Labels
status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sfc-gh-dszmolka @dar-yl