Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1769573: Support describeOnly #940

Closed
gabegorelick opened this issue Oct 28, 2024 · 2 comments
Closed

SNOW-1769573: Support describeOnly #940

gabegorelick opened this issue Oct 28, 2024 · 2 comments
Labels
enhancement The issue is a request for improvement or a new feature status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. status-triage_done Initial triage done, will be further handled by the driver team

Comments

@gabegorelick
Copy link
Contributor

What is the current behavior?

The NodeJS client does not currently support the describeOnly setting to run a describe only query.

What is the desired behavior?

connection.execute({ /* other options not shown */, describeOnly: true })

How would this improve snowflake-connector-nodejs?

Bring the NodeJS client up to parity with other clients like gosnowflake, Java, and .NET that support describeOnly.

References, Other Background

https://pkg.go.dev/github.com/snowflakedb/gosnowflake#WithDescribeOnly

https://github.com/snowflakedb/snowflake-jdbc/blob/83e5849103907f6b48a96c023233f2ca3e024a30/src/main/java/net/snowflake/client/core/SFStatement.java#L116

https://github.com/snowflakedb/snowflake-connector-net/blob/81995633744df22936f82e1d0f135b9b76f03945/Snowflake.Data/Core/SFStatement.cs#L223

@github-actions github-actions bot changed the title Support describeOnly SNOW-1769573: Support describeOnly Oct 28, 2024
gabegorelick added a commit to gabegorelick/snowflake-connector-nodejs that referenced this issue Oct 28, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka added enhancement The issue is a request for improvement or a new feature status-triage_done Initial triage done, will be further handled by the driver team labels Oct 28, 2024
@sfc-gh-dszmolka
Copy link
Collaborator

hi - thanks for raising this suggestion, and also the PR! the team will take a look.

sfc-gh-pmotacki pushed a commit that referenced this issue Nov 4, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka added the status-pr_pending_merge A PR is made and is under review label Nov 5, 2024
sfc-gh-pmotacki pushed a commit that referenced this issue Nov 6, 2024
sfc-gh-pmotacki pushed a commit that referenced this issue Nov 7, 2024
@sfc-gh-dszmolka
Copy link
Collaborator

I see PR #945 has been merged

also released with Snowflake Node.js driver v1.15.0 October 2024 release cycle, so closing this issue.

@sfc-gh-dszmolka sfc-gh-dszmolka added status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. and removed status-pr_pending_merge A PR is made and is under review labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is a request for improvement or a new feature status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants