SNOW-1508219: In type of StatementOption, complete should be optional

[etienne-collibra]

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

After upgrading to 1.11.0 I got a type error cause by a missing complete callback. This callback was optional in @types/snowflake-sdk (link). Looking at the code the callback seems indeed optional.

Here is the diff that solved my problem:

diff --git a/node_modules/snowflake-sdk/index.d.ts b/node_modules/snowflake-sdk/index.d.ts
index 7d494f7..3d5ce77 100644
--- a/node_modules/snowflake-sdk/index.d.ts
+++ b/node_modules/snowflake-sdk/index.d.ts
@@ -491,7 +491,7 @@ declare module 'snowflake-sdk' {
 
     export interface StatementOption {
         sqlText: string;
-        complete: StatementCallback;
+        complete?: StatementCallback;
 
         /**
          * The requestId is for resubmitting requests.

This issue body was partially generated by patch-package.

[sfc-gh-dszmolka]

hi - thank you for the detailed error description! indeed looks to be optional and apparently wasn't addressed in #851 either. we'll look.

[sfc-gh-dszmolka]

#861

[sfc-gh-dszmolka]

fix is now merged and will be part of the next release. Thank you again for your contribution!

[sfc-gh-dszmolka]

released with Snowflake Node.JS driver v1.12.0