Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-981509: Overwriting variable in global scope #712

Closed
pharturs opened this issue Nov 30, 2023 · 3 comments
Closed

SNOW-981509: Overwriting variable in global scope #712

pharturs opened this issue Nov 30, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@pharturs
Copy link
Contributor

Please answer these questions before submitting your issue.
In order to accurately debug the issue this information is required. Thanks!

  1. What version of NodeJS driver are you using?
    1.9.1

  2. What operating system and processor architecture are you using?
    *nix

  3. What version of NodeJS are you using?
    (node --version and npm --version)
    node v18.16.1
    npm 9.5.1

  4. What are the component versions in the environment (npm list)?

npm list
[email protected] 
├── @aws-sdk/[email protected]
├── @aws-sdk/[email protected]
├── @azure/[email protected] overridden
├── @google-cloud/[email protected]
├── @techteamer/[email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
└── [email protected]

5.Server version:* E.g. 1.90.1
You may get the server version by running a query:

SELECT CURRENT_VERSION();

not relevant

  1. What did you do?
    define a global request variable with a value, and observe it is being overwritten after connection to Snowflake is established.
  const connection = snowflake.createConnection(conf);
  await connection.connectAsync();
  1. What did you expect to see?
    no impact to the global environment.

  2. Can you set logging to DEBUG and collect the logs?
    not relevant
    https://community.snowflake.com/s/article/How-to-generate-log-file-on-Snowflake-connectors

e.g
Add this to get standard output.

var snowflake = require('snowflake-sdk');
snowflake.configure(
{
  logLevel: 'trace'
});

not relevant

  1. What is your Snowflake account identifier, if any? (Optional)
    not relevant
@pharturs pharturs added the bug Something isn't working label Nov 30, 2023
@github-actions github-actions bot changed the title Overwriting variable in global scope SNOW-981509: Overwriting variable in global scope Nov 30, 2023
@sfc-gh-dszmolka sfc-gh-dszmolka added the status-in_progress Issue is worked on by the driver team label Nov 30, 2023
@sfc-gh-dszmolka
Copy link
Collaborator

hi - thank you for raising this issue with us and especially already suggesting a solution! thank you for your contribution - we'll review the PR

@sfc-gh-dszmolka sfc-gh-dszmolka added status-pr_pending_merge A PR is made and is under review and removed status-in_progress Issue is worked on by the driver team labels Nov 30, 2023
@sfc-gh-dszmolka
Copy link
Collaborator

your PR is now merged and will be part of the next release. Thank you for your contribution!

@sfc-gh-dszmolka sfc-gh-dszmolka added status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. and removed status-pr_pending_merge A PR is made and is under review labels Dec 5, 2023
@sfc-gh-dszmolka
Copy link
Collaborator

released with 1.9.2, closing

@sfc-gh-dszmolka sfc-gh-dszmolka removed the status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants