Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-949387: Remove unnecessary logging #674

Merged
merged 1 commit into from
Oct 24, 2023
Merged

SNOW-949387: Remove unnecessary logging #674

merged 1 commit into from
Oct 24, 2023

Conversation

sfc-gh-pbulawa
Copy link
Collaborator

Description

Remove unnecessary logging.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team as a code owner October 24, 2023 12:55
sfc-gh-pmotacki
sfc-gh-pmotacki approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 24, 2023 •
edited
Loading

Codecov Report

Merging #674 (67fa1ba) into master (74442f2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #674   +/-   ##
=======================================
  Coverage   87.71%   87.71%           
=======================================
  Files          60       60           
  Lines        5590     5590           
=======================================
  Hits         4903     4903           
  Misses        687      687

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-pbulawa sfc-gh-pbulawa merged commit 93eef4d into master Oct 24, 2023
7 checks passed
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the SNOW-949387 branch October 24, 2023 13:37
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-pbulawa @sfc-gh-pmotacki