-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-922989 Replace deprecated bignumber.js floor function #649
SNOW-922989 Replace deprecated bignumber.js floor function #649
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Thank you for reviewing! Another possible solution would be to set an upper bound on the bignumber.js version in package.json - my initial thought was that my proposed solution would allow moving to the newest versions of that package instead of sticking with the older versions. |
Hi @mblakley, Thanks for your contribution! I have ran your branch in #656 and it seems that the newer version of the Uncaught TypeError: valFracSecsWithTzBig.greaterThanOrEqualTo is not a function
at Object.convertRawTimestampTz [as convert] (/mnt/host/lib/connection/result/column.js:462:30) Could you please take a look into it and update the code? |
I made updates to my branch. Luckily, the API name updates for |
dba848f
to
9cc2af8
Compare
No need to support multiple major versions
cac224d
to
06a7d40
Compare
@mblakley thank you for your contribution. |
Description
Replaced the deprecated
floor
function in new versions of bignumber.js (>= 6.0) with the updated solution of calling.integerValue(BigNumber.ROUND_FLOOR)
Checklist
npm run lint:check -- CHANGED_FILES
and fix problems in changed code) - I ran this, and there are a lot of warnings in the existing column.js file.npm run test:unit
andnpm run test:integration
) - Ran unit tests, no new failures