Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-906755: Warnings about Deprecated Packages #629

Closed
awhitford opened this issue Sep 5, 2023 · 6 comments
Closed

SNOW-906755: Warnings about Deprecated Packages #629

awhitford opened this issue Sep 5, 2023 · 6 comments
Assignees
Labels
bug Something isn't working status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector.

Comments

@awhitford
Copy link

The following warnings were generated by installing snowflake-sdk:

 WARN  deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
 WARN  deprecated [email protected]: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
 WARN  deprecated [email protected]: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
  1. What version of NodeJS driver are you using?
    1.8.0

  2. What operating system and processor architecture are you using?
    Mac OS 13.5.1

  3. What version of NodeJS are you using?
    node: 20.5.1
    pnpm: 8.6.12

  4. What are the component versions in the environment (npm list)?

dependencies:
flowbite 1.8.1
lucide-solid 0.274.0
snowflake-sdk 1.8.0
solid-js 1.7.11

devDependencies:
autoprefixer 10.4.15
postcss 8.4.29
solid-devtools 0.27.7
tailwindcss 3.3.3
typescript 5.2.2
vite 4.4.9
vite-plugin-solid 2.7.0
  1. Server version:
    n/a

  2. What did you do?
    pnpm i snowflake-sdk

  3. What did you expect to see?
    No warnings.

  4. Can you set logging to DEBUG and collect the logs?
    n/a

  5. What is your Snowflake account identifier, if any? (Optional)
    n/a

@awhitford awhitford added the bug Something isn't working label Sep 5, 2023
@github-actions github-actions bot changed the title Warnings about Deprecated Packages SNOW-906755: Warnings about Deprecated Packages Sep 5, 2023
@awhitford
Copy link
Author

awhitford commented Sep 5, 2023

Related to #259 and #616.

@sfc-gh-dszmolka sfc-gh-dszmolka self-assigned this Sep 12, 2023
@sfc-gh-dszmolka sfc-gh-dszmolka added the status-triage Issue is under initial triage label Sep 12, 2023
@sfc-gh-dszmolka
Copy link
Collaborator

hi and thank you for raising this issue. You're right, the uuid deprecation is already planned to be addressed.

The querystring one should be automatically go away after the upgrade to AWS SDK v3 is done (#616) as the deprecated package seems to be an indirect dependency, coming from aws-sdk v2.

Finally for the string-similarity one, we'll take a look and see how best to address it.

@sfc-gh-dszmolka sfc-gh-dszmolka added status-in_progress Issue is worked on by the driver team and removed status-triage Issue is under initial triage labels Sep 12, 2023
@sfc-gh-dszmolka
Copy link
Collaborator

uuid resolved with #637

@alhassanalbadri
Copy link

When should we expect the NPM package to be updated to include the AWS v3 fix?

@sfc-gh-dszmolka
Copy link
Collaborator

sfc-gh-dszmolka commented Sep 19, 2023

for AWS SDK v3, please see #365 (comment) . It's already merged, so will be available with the next version of the driver; towards end of September.

edit: figured I'll create a list-like summary for easier tracking:

@sfc-gh-dszmolka sfc-gh-dszmolka added status-pr_pending_merge A PR is made and is under review status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. and removed status-in_progress Issue is worked on by the driver team status-pr_pending_merge A PR is made and is under review labels Sep 28, 2023
@sfc-gh-dszmolka
Copy link
Collaborator

node.js driver version 1.9.1 released with the fix and is available on npm. thank you all for bearing with us !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector.
Projects
None yet
Development

No branches or pull requests

4 participants