Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-894138: AWS JS SDK v3 Support #619

Closed
jonioni opened this issue Aug 16, 2023 · 1 comment
Closed

SNOW-894138: AWS JS SDK v3 Support #619

jonioni opened this issue Aug 16, 2023 · 1 comment
Assignees

Comments

@jonioni
Copy link

jonioni commented Aug 16, 2023

What is the current behavior?

The Node.js driver is still using aws-sdk (AWS JS SDK v2).

https://github.com/snowflakedb/snowflake-connector-nodejs/blob/dfb780f0f49464b1de15ac01adb5676a73926b22/lib/file_transfer_agent/s3_util.js#L44C2-L44C2

What is the desired behavior?

Use AWS JS SDK v3 since v2 will be deprecate.

How would this improve snowflake-connector-nodejs?

This keeps the package up to date and works better with Lambda Node.js 18.x (LTS) runtime. Also the modular version of the AWS SDK reduces the size of the package.

References, Other Background

It seems this was originally implemented (#337) but then reverted (#345).

@github-actions github-actions bot changed the title AWS JS SDK v3 Support SNOW-894138: AWS JS SDK v3 Support Aug 16, 2023
@sfc-gh-dszmolka sfc-gh-dszmolka self-assigned this Aug 16, 2023
@sfc-gh-dszmolka
Copy link
Collaborator

hi and thank you for raising this issue ! since the work is already tracked on #365, i'm closing this as a duplicate.

@sfc-gh-dszmolka sfc-gh-dszmolka closed this as not planned Won't fix, can't repro, duplicate, stale Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants