Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MFA token caching #493

Closed
nathanjcochran opened this issue May 16, 2023 · 9 comments
Closed

Add support for MFA token caching #493

nathanjcochran opened this issue May 16, 2023 · 9 comments
Assignees
Labels
enhancement The issue is a request for improvement or a new feature parity this feature is supported in other drivers status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector.

Comments

@nathanjcochran
Copy link

nathanjcochran commented May 16, 2023

What is the current behavior?

Every time a new connection is created, a new Duo MFA prompt is triggered. When creating multiple connections in quick succession, this can be very annoying. It is easy to miss one or more of the prompts, which can cause you to be locked out of your account for awhile.

What is the desired behavior?

The Duo MFA prompt is only triggered for the first connection made in some time window, because the MFA token is cached. Basically, add support for MFA Token Caching.

How would this improve snowflake-connector-nodejs?

It would reduce the number of repeated Duo MFA prompts that users have to approve when an application using the node.js snowflake driver makes multiple connections in quick succession.

References, Other Background

Official documentation on MFA Token Caching.

@nathanjcochran nathanjcochran changed the title Add support for caching MFA tokens Add support for MFA token caching May 16, 2023
@sfc-gh-dszmolka sfc-gh-dszmolka self-assigned this May 23, 2023
@sfc-gh-dszmolka sfc-gh-dszmolka added the status-triage Issue is under initial triage label May 23, 2023
@sfc-gh-dszmolka
Copy link
Collaborator

hello and thank you for submitting this enhancement request. we'll take a look and i'll try to keep this Issue updated with the news. thank you in advance for bearing with us !

@sfc-gh-dszmolka sfc-gh-dszmolka added enhancement The issue is a request for improvement or a new feature parity this feature is supported in other drivers and removed status-triage Issue is under initial triage labels May 23, 2023
@john-pavlat
Copy link

+1 on this issue; this would be incredibly helpful for serverless applications.

@Oracen
Copy link

Oracen commented Apr 15, 2024

Quick +1 to this. Is there an approximate ETA on this? Last update was 4 months ago

@sfc-gh-dszmolka
Copy link
Collaborator

sfc-gh-dszmolka commented Apr 15, 2024

apologies it taking so long, but being an entirely new feature which on top of it, operates on user credentials, we also had to go through a (lengthy) internal security review before the actual implementation.

Feature PR's can be followed here:

As of now, I cannot give a specific ETA for the actual implementation, but syncing internally with the team and will update if there's any more specifics.

edit: there is - we aim to release both features in the April release cycle (happens usually towards end of given month) so fingers crossed !

@jonathankkizer
Copy link

Is there an update for this? I see that it missed the April release cycle. Is it likely that it is shipped in the next few months?

@sfc-gh-dszmolka
Copy link
Collaborator

you can follow the linked PRs for updates. We plan to release this in the upcoming months indeed (there were other priorities so this fell back a bit). Thank you for bearing with us !

@sfc-gh-dszmolka
Copy link
Collaborator

PR #820 for SSO token caching is now merged, and will be part of the next upcoming release.
We keep working on the MFA token caching #711 too, to be released hopefully at the same time.

@sfc-gh-dszmolka sfc-gh-dszmolka added status-pr_pending_merge A PR is made and is under review and removed status-in_progress Issue is worked on by the driver team labels Jun 27, 2024
@sfc-gh-dszmolka
Copy link
Collaborator

MFA token caching PR also merged, and both SSO and MFA token caching will be part of the next upcoming release in July 2024.

@sfc-gh-dszmolka sfc-gh-dszmolka added status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. and removed status-pr_pending_merge A PR is made and is under review labels Jul 5, 2024
@sfc-gh-dszmolka
Copy link
Collaborator

released with Snowflake Node.JS driver v1.12.0 - thank you for bearing with us !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is a request for improvement or a new feature parity this feature is supported in other drivers status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector.
Projects
None yet
Development

No branches or pull requests

7 participants