From 4ca6b2b0121bac2e31d783ef90c41fba0be5076a Mon Sep 17 00:00:00 2001
From: Adam Kolodziejczyk <adam.kolodziejczyk@snowflake.com>
Date: Wed, 4 Dec 2024 09:36:51 +0100
Subject: [PATCH] add todos

---
 ci/test_authentication.sh          | 2 +-
 test/authentication/testKeyPair.js | 1 +
 test/authentication/testOkta.js    | 5 +++--
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/ci/test_authentication.sh b/ci/test_authentication.sh
index 02baada7f..49ab3ae26 100755
--- a/ci/test_authentication.sh
+++ b/ci/test_authentication.sh
@@ -13,5 +13,5 @@ docker run \
   -v $(cd $THIS_DIR/.. && pwd):/mnt/host \
   -v $WORKSPACE:/mnt/workspace \
   --rm \
-  nexus.int.snowflakecomputing.com:8086/docker/snowdrivers-test-external-browser:2 \
+  nexus.int.snowflakecomputing.com:8086/docker/snowdrivers-test-external-browser:3 \
   "/mnt/host/ci/container/test_authentication.sh"
diff --git a/test/authentication/testKeyPair.js b/test/authentication/testKeyPair.js
index a85a1513d..60b48df28 100644
--- a/test/authentication/testKeyPair.js
+++ b/test/authentication/testKeyPair.js
@@ -73,6 +73,7 @@ describe('Key-pair authentication', function () {
       await authTest.verifyConnectionIsUp();
     });
 
+    //todo SNOW-1844747 improve error message
     it('Invalid private key password', async function () {
       const connectionOption = { ...connParameters.keypairEncryptedPrivateKeyPath, privateKeyPass: 'invalid' };
       authTest.createConnection(connectionOption);
diff --git a/test/authentication/testOkta.js b/test/authentication/testOkta.js
index 4a4105530..1230bb0db 100644
--- a/test/authentication/testOkta.js
+++ b/test/authentication/testOkta.js
@@ -28,11 +28,12 @@ describe('Okta authentication', function () {
     await authTest.verifyConnectionIsNotUp();
   });
 
-  it.skip('Wrong okta url', async function () {
+  //todo SNOW-1844747 improve error message
+  it('Wrong okta url', async function () {
     const connectionOption = { ...connParameters.okta, authenticator: 'https://testinvalidaccoount.com' };
     authTest.createConnection(connectionOption);
     await authTest.connectAsync();
-    authTest.verifyErrorWasThrown('');
+    authTest.verifyErrorWasThrown('Cannot read properties of null (reading \'ssoUrl\')');
     await authTest.verifyConnectionIsNotUp();
   });
 });