From 6003572369efa760ca831887c347ca6dab4c0f1b Mon Sep 17 00:00:00 2001
From: Juan Martinez Ramirez <juan.martinezramirez@snowflake.com>
Date: Tue, 9 Apr 2024 15:41:23 -0600
Subject: [PATCH 1/4] POC to generate conditional build for exclude cloud
 providers.

---
 Snowflake.Data/Snowflake.Data.csproj | 46 +++++++++++++++++++++++++---
 1 file changed, 41 insertions(+), 5 deletions(-)

diff --git a/Snowflake.Data/Snowflake.Data.csproj b/Snowflake.Data/Snowflake.Data.csproj
index 0621c5fb0..0a37fc2d9 100644
--- a/Snowflake.Data/Snowflake.Data.csproj
+++ b/Snowflake.Data/Snowflake.Data.csproj
@@ -2,8 +2,7 @@
   <PropertyGroup>
     <TargetFrameworks>net6.0;net471;net472</TargetFrameworks>
     <TargetFrameworks Condition="'$(OS)' != 'Windows_NT'">net6.0</TargetFrameworks>
-    <Title>Snowflake.Data</Title>
-    <PackageId>Snowflake.Data</PackageId>
+    <ExcludeProviderDependencies Condition="'$(ExcludeProviderDependencies)'==''">false</ExcludeProviderDependencies>
     <PackageLicenseUrl>https://github.com/snowflakedb/snowflake-connector-net/blob/master/LICENSE</PackageLicenseUrl>
     <PackageProjectUrl>https://github.com/snowflakedb/snowflake-connector-net</PackageProjectUrl>
     <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
@@ -17,13 +16,50 @@
     <DebugType>Full</DebugType>
     <LangVersion>7.3</LangVersion>
   </PropertyGroup>
-  
-  <ItemGroup>
-    <PackageReference Include="Apache.Arrow" Version="14.0.2" />
+
+  <PropertyGroup Condition="'$(ExcludeProviderDependencies)'=='false'">
+    <Title>Snowflake.Data</Title>
+    <PackageId>Snowflake.Data</PackageId>
+    <Description>Snowflake Connector for .NET</Description>
+  </PropertyGroup>
+  <PropertyGroup Condition="'$(ExcludeProviderDependencies)'=='true'">
+    <Title>Snowflake.Data.Core</Title>
+    <PackageId>Snowflake.Data.Core</PackageId>
+    <Description>Snowflake Connector for .NET</Description>
+  </PropertyGroup>
+
+  <ItemGroup Condition="'$(ExcludeProviderDependencies)'=='true'">
+
+    <PackageReference Include="AWSSDK.S3" Version="3.7.0.4" >
+      <ExcludeAssets>Runtime,Build,Native,Analyzers,BuildTransitive</ExcludeAssets>
+      <IncludeAssets>compile</IncludeAssets>
+    </PackageReference>
+    <PackageReference Include="Google.Cloud.Storage.V1" Version="4.6.0">
+      <ExcludeAssets>Runtime,Build,Native,Analyzers,BuildTransitive</ExcludeAssets>
+      <IncludeAssets>compile</IncludeAssets>
+    </PackageReference>
+    <PackageReference Include="Azure.Storage.Blobs" Version="12.13.0" >
+      <ExcludeAssets>Runtime,Build,Native,Analyzers,BuildTransitive</ExcludeAssets>
+      <IncludeAssets>compile</IncludeAssets>
+    </PackageReference>
+    <PackageReference Include="Azure.Storage.Common" Version="12.12.0" >
+      <ExcludeAssets>Runtime,Build,Native,Analyzers,BuildTransitive</ExcludeAssets>
+      <IncludeAssets>compile</IncludeAssets>
+    </PackageReference>
+
+  </ItemGroup>
+
+  <ItemGroup Condition="'$(ExcludeProviderDependencies)'=='false'">
+
     <PackageReference Include="AWSSDK.S3" Version="3.7.0.4" />
     <PackageReference Include="Google.Cloud.Storage.V1" Version="4.6.0" />
     <PackageReference Include="Azure.Storage.Blobs" Version="12.13.0" />
     <PackageReference Include="Azure.Storage.Common" Version="12.12.0" />
+
+  </ItemGroup>
+  
+  <ItemGroup>
+    <PackageReference Include="Apache.Arrow" Version="14.0.2" />
     <PackageReference Include="Mono.Unix" Version="7.1.0-final.1.21458.1" />
     <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
     <PackageReference Include="log4net" Version="2.0.12" />

From 536a9a65212e9e15172c4b5016273b1fcc3a6d39 Mon Sep 17 00:00:00 2001
From: Juan Martinez Ramirez <juan.martinezramirez@snowflake.com>
Date: Fri, 12 Apr 2024 18:16:34 -0600
Subject: [PATCH 2/4] Nuspec for AWS dependencies

This requires using Nuget.exe to be generated using the next command:
nuget.exe pack snowflake.data.aws.nuspec -Exclude **
---
 Snowflake.Data/snowflake.data.aws.nuspec | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100755 Snowflake.Data/snowflake.data.aws.nuspec

diff --git a/Snowflake.Data/snowflake.data.aws.nuspec b/Snowflake.Data/snowflake.data.aws.nuspec
new file mode 100755
index 000000000..03ffff8b1
--- /dev/null
+++ b/Snowflake.Data/snowflake.data.aws.nuspec
@@ -0,0 +1,20 @@
+<?xml version="1.0" encoding="utf-8"?>
+<package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd">
+  <metadata>
+    <id>Snowflake.Data.AWS</id>
+    <version>3.1.0</version>
+    <title>Snowflake.Data.AWS</title>
+    <authors>howryu, tchen</authors>
+    <requireLicenseAcceptance>true</requireLicenseAcceptance>
+    <licenseUrl>https://github.com/snowflakedb/snowflake-connector-net/blob/master/LICENSE</licenseUrl>
+    <projectUrl>https://github.com/snowflakedb/snowflake-connector-net</projectUrl>
+    <iconUrl>https://raw.githubusercontent.com/snowflakedb/snowflake-connector-net/master/Snowflake.Data/snowflake.ico</iconUrl>
+    <description>Snowflake Connector for .NET</description>
+    <copyright>Copyright (c) 2012-2023 Snowflake Computing Inc. All rights reserved.</copyright>
+    <dependencies>
+      <group targetFramework="net6.0">
+        <dependency id="AWSSDK.S3" version="3.7.0.4" exclude="Build,Analyzers" />
+      </group>
+    </dependencies>
+  </metadata>
+</package>
\ No newline at end of file

From 773105c778f70e0c590e66a7460fb96e670c7241 Mon Sep 17 00:00:00 2001
From: Juan Martinez Ramirez <juan.martinezramirez@snowflake.com>
Date: Wed, 17 Apr 2024 10:03:42 -0600
Subject: [PATCH 3/4] Moved nuspec to providers folder

---
 .../Snowflake.Data.AWS.Dependencies.nuspec}            | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
 rename Snowflake.Data/{snowflake.data.aws.nuspec => providers/Snowflake.Data.AWS.Dependencies.nuspec} (75%)
 mode change 100755 => 100644

diff --git a/Snowflake.Data/snowflake.data.aws.nuspec b/Snowflake.Data/providers/Snowflake.Data.AWS.Dependencies.nuspec
old mode 100755
new mode 100644
similarity index 75%
rename from Snowflake.Data/snowflake.data.aws.nuspec
rename to Snowflake.Data/providers/Snowflake.Data.AWS.Dependencies.nuspec
index 03ffff8b1..d078d42e1
--- a/Snowflake.Data/snowflake.data.aws.nuspec
+++ b/Snowflake.Data/providers/Snowflake.Data.AWS.Dependencies.nuspec
@@ -1,18 +1,18 @@
 <?xml version="1.0" encoding="utf-8"?>
 <package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd">
   <metadata>
-    <id>Snowflake.Data.AWS</id>
+    <id>Snowflake.Data.AWS.Dependencies</id>
     <version>3.1.0</version>
-    <title>Snowflake.Data.AWS</title>
-    <authors>howryu, tchen</authors>
+    <title>Snowflake.Data.AWS.Dependencies</title>
+    <authors>Snowflake</authors>
     <requireLicenseAcceptance>true</requireLicenseAcceptance>
     <licenseUrl>https://github.com/snowflakedb/snowflake-connector-net/blob/master/LICENSE</licenseUrl>
     <projectUrl>https://github.com/snowflakedb/snowflake-connector-net</projectUrl>
     <iconUrl>https://raw.githubusercontent.com/snowflakedb/snowflake-connector-net/master/Snowflake.Data/snowflake.ico</iconUrl>
-    <description>Snowflake Connector for .NET</description>
+    <description>Snowflake Connector AWS dependencies for .NET</description>
     <copyright>Copyright (c) 2012-2023 Snowflake Computing Inc. All rights reserved.</copyright>
     <dependencies>
-      <group targetFramework="net6.0">
+      <group targetFramework="netstandard2.0">
         <dependency id="AWSSDK.S3" version="3.7.0.4" exclude="Build,Analyzers" />
       </group>
     </dependencies>

From 7c0587d7aba8c19f04cadc1383fb4a7813aa7655 Mon Sep 17 00:00:00 2001
From: Juan Martinez Ramirez <juan.martinezramirez@snowflake.com>
Date: Wed, 17 Apr 2024 10:04:54 -0600
Subject: [PATCH 4/4] Removed conditional build

---
 Snowflake.Data/Snowflake.Data.csproj | 32 +++++-----------------------
 1 file changed, 5 insertions(+), 27 deletions(-)

diff --git a/Snowflake.Data/Snowflake.Data.csproj b/Snowflake.Data/Snowflake.Data.csproj
index 0a37fc2d9..e04f8d0cf 100644
--- a/Snowflake.Data/Snowflake.Data.csproj
+++ b/Snowflake.Data/Snowflake.Data.csproj
@@ -2,7 +2,9 @@
   <PropertyGroup>
     <TargetFrameworks>net6.0;net471;net472</TargetFrameworks>
     <TargetFrameworks Condition="'$(OS)' != 'Windows_NT'">net6.0</TargetFrameworks>
-    <ExcludeProviderDependencies Condition="'$(ExcludeProviderDependencies)'==''">false</ExcludeProviderDependencies>
+    <Title>Snowflake.Data</Title>
+    <PackageId>Snowflake.Data</PackageId>
+    <Description>Snowflake Connector for .NET</Description>
     <PackageLicenseUrl>https://github.com/snowflakedb/snowflake-connector-net/blob/master/LICENSE</PackageLicenseUrl>
     <PackageProjectUrl>https://github.com/snowflakedb/snowflake-connector-net</PackageProjectUrl>
     <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
@@ -16,19 +18,8 @@
     <DebugType>Full</DebugType>
     <LangVersion>7.3</LangVersion>
   </PropertyGroup>
-
-  <PropertyGroup Condition="'$(ExcludeProviderDependencies)'=='false'">
-    <Title>Snowflake.Data</Title>
-    <PackageId>Snowflake.Data</PackageId>
-    <Description>Snowflake Connector for .NET</Description>
-  </PropertyGroup>
-  <PropertyGroup Condition="'$(ExcludeProviderDependencies)'=='true'">
-    <Title>Snowflake.Data.Core</Title>
-    <PackageId>Snowflake.Data.Core</PackageId>
-    <Description>Snowflake Connector for .NET</Description>
-  </PropertyGroup>
-
-  <ItemGroup Condition="'$(ExcludeProviderDependencies)'=='true'">
+  
+  <ItemGroup>
 
     <PackageReference Include="AWSSDK.S3" Version="3.7.0.4" >
       <ExcludeAssets>Runtime,Build,Native,Analyzers,BuildTransitive</ExcludeAssets>
@@ -46,19 +37,6 @@
       <ExcludeAssets>Runtime,Build,Native,Analyzers,BuildTransitive</ExcludeAssets>
       <IncludeAssets>compile</IncludeAssets>
     </PackageReference>
-
-  </ItemGroup>
-
-  <ItemGroup Condition="'$(ExcludeProviderDependencies)'=='false'">
-
-    <PackageReference Include="AWSSDK.S3" Version="3.7.0.4" />
-    <PackageReference Include="Google.Cloud.Storage.V1" Version="4.6.0" />
-    <PackageReference Include="Azure.Storage.Blobs" Version="12.13.0" />
-    <PackageReference Include="Azure.Storage.Common" Version="12.12.0" />
-
-  </ItemGroup>
-  
-  <ItemGroup>
     <PackageReference Include="Apache.Arrow" Version="14.0.2" />
     <PackageReference Include="Mono.Unix" Version="7.1.0-final.1.21458.1" />
     <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />